public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Holger Brunck <holger.brunck@keymile.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot,PATCHv4] Optimized nand_read_buf for kirkwood
Date: Thu, 14 Nov 2013 09:18:41 +0100	[thread overview]
Message-ID: <52848761.3080004@keymile.com> (raw)
In-Reply-To: <20131114013102.GA12213@home.buserror.net>

Hi Scott,

On 11/14/2013 02:31 AM, Scott Wood wrote:
> On Mon, Aug 26, 2013 at 02:10:56PM +0200, Phil Sutter wrote:
>> From: Nico Erfurth <ne@erfurth.eu>
>>
>> The basic idea is taken from the linux-kernel, but further optimized.
>>
>> First align the buffer to 8 bytes, then use ldrd/strd to read and store
>> in 8 byte quantities, then do the final bytes.
>>
>> Tested using: 'date ; nand read.raw 0xE00000 0x0 0x10000 ; date'.
>> Without this patch, NAND read of 132MB took 49s (~2.69MB/s). With this
>> patch in place, reading the same amount of data was done in 27s
>> (~4.89MB/s). So read performance is increased by ~80%!
>>
>> Signed-off-by: Nico Erfurth <ne@erfurth.eu>
>> Tested-by: Phil Sutter <phil.sutter@viprinet.com>
>> Cc: Prafulla Wadaskar <prafulla@marvell.com>
>>
>> ---
>> Changed since V3:
>> - fixed author
>> ---
>>  drivers/mtd/nand/kirkwood_nand.c | 32 ++++++++++++++++++++++++++++++++
>>  1 file changed, 32 insertions(+)
> 
> I tried to build-test this, and I couldn't find any board that defines
> CONFIG_NAND_KIRKWOOD.
> 

it's not in board specific code defined it's defined in a common kirkwood header:

arch/arm/include/asm/arch-kirkwood/config.h:58:#define CONFIG_NAND_KIRKWOOD

> The patch that removed it was commit
> b5befd8211b54ae2d2fca3fbed061c879951ceaa ("arm/km: fix u-boot.kwb build
> breakage"), over two years ago.  It's not clear whether the removal was
> intentional.
>

yes it was. We include this common header and therefore we don't need to
redefine it in our board setup.

Regards
Holger

  reply	other threads:[~2013-11-14  8:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-26 12:10 [U-Boot] [PATCHv4] Optimized nand_read_buf for kirkwood Phil Sutter
2013-08-26 15:43 ` Scott Wood
2013-08-26 16:00   ` Phil Sutter
2013-08-26 16:06     ` Phil Sutter
2013-11-14  1:31 ` [U-Boot] [U-Boot,PATCHv4] " Scott Wood
2013-11-14  8:18   ` Holger Brunck [this message]
2013-11-14 23:59     ` Scott Wood
2013-11-14 12:12   ` Phil Sutter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52848761.3080004@keymile.com \
    --to=holger.brunck@keymile.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox