From: Eric Nelson <eric.nelson@boundarydevices.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] i.MX6: nitrogen6x: update memory configuration files to use macros
Date: Thu, 14 Nov 2013 14:28:35 -0700 [thread overview]
Message-ID: <52854083.9040401@boundarydevices.com> (raw)
In-Reply-To: <201311142220.38057.marex@denx.de>
Hi Marek,
On 11/14/2013 02:20 PM, Marek Vasut wrote:
> Dear Eric Nelson,
>
>> This patch updates the memory configuration files for the Nitrogen6X
>> boards to use macros to define the output for imximage. This allows
>> re-use of the same files of register/value pairs to be included from C
>> as a pre-cursor to run-time detection of the memory size on a board.
>>
>> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
>> ---
>> board/boundary/nitrogen6x/1066mhz_4x128mx16.cfg | 72
>> ++++++++++++------------- board/boundary/nitrogen6x/1066mhz_4x256mx16.cfg
>> | 72 ++++++++++++-------------
>> board/boundary/nitrogen6x/800mhz_2x128mx16.cfg | 72
>> ++++++++++++------------- board/boundary/nitrogen6x/800mhz_2x256mx16.cfg
>> | 72 ++++++++++++-------------
>> board/boundary/nitrogen6x/800mhz_4x128mx16.cfg | 72
>> ++++++++++++------------- board/boundary/nitrogen6x/800mhz_4x256mx16.cfg
>> | 72 ++++++++++++------------- board/boundary/nitrogen6x/nitrogen6dl.cfg
>> | 1 +
>> board/boundary/nitrogen6x/nitrogen6dl2g.cfg | 1 +
>> board/boundary/nitrogen6x/nitrogen6q.cfg | 1 +
>> board/boundary/nitrogen6x/nitrogen6q2g.cfg | 1 +
>> board/boundary/nitrogen6x/nitrogen6s.cfg | 1 +
>> board/boundary/nitrogen6x/nitrogen6s1g.cfg | 1 +
>> 12 files changed, 222 insertions(+), 216 deletions(-)
>
> I dont mind either way, but just an idea for discussion:
>
> What do you say to implementing the DRAM controller programming in SPL? That
> way, we can even do proper DRAM calibration on boot and other such nice things.
> And we'd also get rid of these static magic numbers all around.
>
We can (and hopefully will very soon) implement some of the
configuration in C under SPL, but we can't (and shouldn't) get
rid of all of the magic numbers.
Some of these numbers come from testing large numbers of devices
under a variety of temperature conditions. The best that the
automagic calibration facilities can do is set things up based
on nominal current conditions.
That said, I'm sure we can cut down on the total number.
My immediate goal is simply to set the stage for SPL and
a single binary.
Regards,
Eric
next prev parent reply other threads:[~2013-11-14 21:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-14 18:30 [U-Boot] [PATCH] i.MX6: nitrogen6x: update memory configuration files to use macros Eric Nelson
2013-11-14 21:20 ` Marek Vasut
2013-11-14 21:28 ` Eric Nelson [this message]
2013-11-14 23:32 ` Marek Vasut
2013-11-18 9:32 ` Stefano Babic
2013-11-18 14:21 ` Eric Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52854083.9040401@boundarydevices.com \
--to=eric.nelson@boundarydevices.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox