From mboxrd@z Thu Jan  1 00:00:00 1970
From: Pierre AUBERT <p.aubert@staubli.com>
Date: Fri, 15 Nov 2013 08:20:09 +0100
Subject: [U-Boot] [PATCH 2/2] env export fix: compute the CRC on the
 real lenght of the exported variables.
In-Reply-To: <20131114172423.A3845380C60@gemini.denx.de>
References: <1384434720-11214-1-git-send-email-p.aubert@staubli.com>
	<1384434720-11214-3-git-send-email-p.aubert@staubli.com>
	<20131114172423.A3845380C60@gemini.denx.de>
Message-ID: <5285CB29.6030903@staubli.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Wolfgang Denk,

Le 14/11/2013 18:24, Wolfgang Denk a ?crit :
> Dear Pierre Aubert,
>
> In message <1384434720-11214-3-git-send-email-p.aubert@staubli.com> you wrote:
>> Signed-off-by: Pierre Aubert <p.aubert@staubli.com>
>> ---
>>   common/cmd_nvedit.c |    5 +++--
>>   1 files changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/common/cmd_nvedit.c b/common/cmd_nvedit.c
>> index 5bcc324..c32a932 100644
>> --- a/common/cmd_nvedit.c
>> +++ b/common/cmd_nvedit.c
>> @@ -922,14 +922,15 @@ NXTARG:		;
>>   
>>   	len = hexport_r(&env_htab, '\0',
>>   			H_MATCH_KEY | H_MATCH_IDENT,
>> -			&res, ENV_SIZE, argc, argv);
>> +			&res, size, argc, argv);
>> +
>>   	if (len < 0) {
>>   		error("Cannot export environment: errno = %d\n", errno);
>>   		return 1;
>>   	}
>>   
>>   	if (chk) {
>> -		envp->crc = crc32(0, envp->data, ENV_SIZE);
>> +		envp->crc = crc32(0, envp->data, len);
> This is not correct.  When exporting with CRC, then the CRC
> computation should be the same as is done with the persistently
> stored environment, i. e. it should be taken over ENV_SIZE bytes.
In this case, there's an inconstisency between the export and the 
import. It isn't possible to export some variables and the reimport them:
U-Boot > env export -c <addr>
U-Boot > env import -c <same addr> fails with a CRC error.
The import computes the CRC on the real lenght of the environment 
variables. IMO, as the import and the export are done to work together, 
it seems to me that the export should compute its CRC on the real  lenght.

Best regards
>
> Best regards,
>
> Wolfgang Denk
>