From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Nelson <eric.nelson@boundarydevices.com>
Date: Mon, 18 Nov 2013 20:25:13 -0700
Subject: [U-Boot] [PATCH V3 1/5] i.MX5x: define cpu_type() to return
 processor portion of cpu rev.
In-Reply-To: <5289EF32.7010403@denx.de>
References: <1384708667-22489-1-git-send-email-eric.nelson@boundarydevices.com>
	<1384708667-22489-2-git-send-email-eric.nelson@boundarydevices.com>
	<5289EF32.7010403@denx.de>
Message-ID: <528ADA19.3010708@boundarydevices.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Stefano,
On 11/18/2013 03:42 AM, Stefano Babic wrote:
> Hi Eric,
>
> On 17/11/2013 18:17, Eric Nelson wrote:
>> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
>> ---
>> This patch is new in V3
>>
>>   arch/arm/include/asm/arch-mx5/sys_proto.h | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/arch/arm/include/asm/arch-mx5/sys_proto.h b/arch/arm/include/asm/arch-mx5/sys_proto.h
>> index 9949ad1..9dad5fc 100644
>> --- a/arch/arm/include/asm/arch-mx5/sys_proto.h
>> +++ b/arch/arm/include/asm/arch-mx5/sys_proto.h
>> @@ -17,6 +17,10 @@
>>
>>   #define is_soc_rev(rev)	((get_cpu_rev() & 0xFF) - rev)
>>   u32 get_cpu_rev(void);
>> +
>> +/* returns MXC_CPU_ value */
>> +#define cpu_type(rev) (((rev) >> 12)&0xff)
>> +
>
> There is already a get_cpu_type() for other architectures (OMAP). We do
> not need to reinvent the wheel this time, and it is correct to add
> get_cpu_type(void) to sys_proto.h.
>
> This lets also easier to understand the code because it can be directly
> derived from the User's Manual: shifting 12 bit in your macro is only
> because this is done in get_cpu_rev(), not because this is the offset in
> the i.MX6 register.
>

Okay. I'll re-submit with get_cpu_type(void) implemented imx-common/cpu.c.

I still question the fact that we have two header files for i.MX5x
and i.MX6x declaring the returns implemented there.

It seems that we should have a single header for routines
implemented there.

Perhaps arch/arm/include/imx-common/cpu.h?

Please advise,


Eric