public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Lubomir Popov <lpopov@mm-sol.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM: OMAP4: Fix bug in omap4470_volts struct
Date: Wed, 20 Nov 2013 15:32:17 +0200	[thread overview]
Message-ID: <528CB9E1.3040200@mm-sol.com> (raw)

The struct incorrectly referenced SMPS1 for all three power
domains. Fixed this by using SMPS2 and SMPS5 as appropriate.

Add some comments and choose voltage values that correspond
to voltage selection codes.

Signed-off-by: Lubomir Popov <l-popov@ti.com>
---
  arch/arm/cpu/armv7/omap4/hw_data.c |   12 ++++++++----
  1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/arch/arm/cpu/armv7/omap4/hw_data.c b/arch/arm/cpu/armv7/omap4/hw_data.c
index 6a225c8..1b2f439 100644
--- a/arch/arm/cpu/armv7/omap4/hw_data.c
+++ b/arch/arm/cpu/armv7/omap4/hw_data.c
@@ -288,17 +288,21 @@ struct vcores_data omap4460_volts = {
      .mm.pmic = &twl6030,
  };

+/*
+ * Take closest integer part of the mV value corresponding to a TWL6032 SMPS
+ * voltage selection code. Aligned with OMAP4470 ES1.0 OCA V.0.7.
+ */
  struct vcores_data omap4470_volts = {
-    .mpu.value = 1200,
+    .mpu.value = 1202,
      .mpu.addr = SMPS_REG_ADDR_SMPS1,
      .mpu.pmic = &twl6030,

      .core.value = 1126,
-    .core.addr = SMPS_REG_ADDR_SMPS1,
+    .core.addr = SMPS_REG_ADDR_SMPS2,
      .core.pmic = &twl6030,

-    .mm.value = 1137,
-    .mm.addr = SMPS_REG_ADDR_SMPS1,
+    .mm.value = 1139,
+    .mm.addr = SMPS_REG_ADDR_SMPS5,
      .mm.pmic = &twl6030,
  };

-- 
1.7.9.5

             reply	other threads:[~2013-11-20 13:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-20 13:32 Lubomir Popov [this message]
2013-12-04 22:04 ` [U-Boot] ARM: OMAP4: Fix bug in omap4470_volts struct Tom Rini
2013-12-05 11:39   ` Lubomir Popov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=528CB9E1.3040200@mm-sol.com \
    --to=lpopov@mm-sol.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox