public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/5] mx6sabre{auto, sd}: Change FDT loading address to avoid overlaping
Date: Thu, 21 Nov 2013 10:00:59 +0100	[thread overview]
Message-ID: <528DCBCB.1000901@denx.de> (raw)
In-Reply-To: <CAP9ODKp5DWJ_xgH4ZK3B=pHrA7U8BX4uB4V-1CNDE+tRYBgp4A@mail.gmail.com>

Hi Otavio, Jason, Fabio,

On 18/11/2013 20:39, Otavio Salvador wrote:

> 
> What is the final decision on this? I have the same change for many
> boards which are/will be supported by 3.10.
> 

You're right, we need a decision. As far as I read, there is no
explanation why this change is required. As Fabio points out, dtb is
loaded before the kernel and this should avoid an overlap. It will be
very nice if Jason could better explain the issue, because I admit I
have not understood why it happens.

Maybe is DTB loaded after the kernel on Freescale's U-Boot ?

This is clearly a work-around for a bug in Freescale's kernel 3.10, as
we have no problems with other kernels. I booted mainline kernel
3.11/3.12 on a i.MX6 without this issue.

However, I could still merge the patch if we can at least have the
following answers:

- why is there the overlap if the kernel is loaded after DTB (Fabio's
question) ?
- add the explanation to the commit message (so V2 is required, this is
also a Wolfgang's comment).
- of course, the patch should generate a problem with other kernels. It
should not be, but a couple of tested-by will be nice.

As the patchset fixes the same issue, I would prefer if the patchset is
squashed into a single patch because it fixes a single issue and we can
have only one "extended" commit message with the whole explanation.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

  reply	other threads:[~2013-11-21  9:00 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-01 11:25 [U-Boot] [PATCH 1/5] mx6sabre{auto, sd}: Change FDT loading address to avoid overlaping Otavio Salvador
2013-11-01 11:25 ` [U-Boot] [PATCH 2/5] wandboard: " Otavio Salvador
2013-11-01 11:25 ` [U-Boot] [PATCH 3/5] udoo: " Otavio Salvador
2013-11-01 12:40   ` Wolfgang Denk
2013-11-01 13:05     ` Otavio Salvador
2013-11-01 20:24       ` Wolfgang Denk
2013-11-01 11:25 ` [U-Boot] [PATCH 4/5] nitrogen6x: " Otavio Salvador
2013-11-01 12:19   ` Marek Vasut
2013-11-01 13:06     ` Otavio Salvador
2013-11-01 14:08       ` Marek Vasut
2013-11-01 11:25 ` [U-Boot] [PATCH 5/5] cgtqmx6eval: " Otavio Salvador
2013-11-01 12:25 ` [U-Boot] [PATCH 1/5] mx6sabre{auto, sd}: " Fabio Estevam
2013-11-01 13:00   ` Otavio Salvador
2013-11-01 14:18     ` Fabio Estevam
     [not found]       ` <AD13664F485EE54694E29A7F9D5BE1AFB499F8@039-SN2MPN1-022.039d.mgd.msft.net>
2013-11-18 19:39         ` Otavio Salvador
2013-11-21  9:00           ` Stefano Babic [this message]
2013-11-21 13:06             ` Otavio Salvador
2013-11-23  5:52             ` Hui Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=528DCBCB.1000901@denx.de \
    --to=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox