* [U-Boot] patchwork does not pick my patch @ 2013-11-21 11:14 Masahiro Yamada 2013-11-21 11:32 ` Andreas Bießmann 0 siblings, 1 reply; 5+ messages in thread From: Masahiro Yamada @ 2013-11-21 11:14 UTC (permalink / raw) To: u-boot Hi. I posted a patch to change a file permission. This: http://lists.denx.de/pipermail/u-boot/2013-November/167573.html and again: http://lists.denx.de/pipermail/u-boot/2013-November/167608.html But my patch would not appear on patchwork. (Maybe because there is no diff line.) What should I do? Is it better to squash it to another patch? Best Regard Masahiro Yamada ^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] patchwork does not pick my patch 2013-11-21 11:14 [U-Boot] patchwork does not pick my patch Masahiro Yamada @ 2013-11-21 11:32 ` Andreas Bießmann 2013-11-21 23:14 ` Jeremy Kerr 2013-11-26 1:19 ` Masahiro Yamada 0 siblings, 2 replies; 5+ messages in thread From: Andreas Bießmann @ 2013-11-21 11:32 UTC (permalink / raw) To: u-boot Dear Masahiro Yamada, +patchwork list On 11/21/2013 12:14 PM, Masahiro Yamada wrote: > Hi. > > I posted a patch to change a file permission. > This: > http://lists.denx.de/pipermail/u-boot/2013-November/167573.html > > and again: > http://lists.denx.de/pipermail/u-boot/2013-November/167608.html > > > But my patch would not appear on patchwork. > (Maybe because there is no diff line.) I think so too. There is some handling for renames without patch in patchwork, but I think there is no handling for just file permission changes. That should be fixed in patchwork then. > What should I do? File bug report at patchwork ML? > Is it better to squash it to another patch? Well to show it up in patchwork that could work. Since this change is quite trivial I think it will also work if you just peak the relevant custodian to pick this from the list. Best regards Andreas Bie?mann ^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] patchwork does not pick my patch 2013-11-21 11:32 ` Andreas Bießmann @ 2013-11-21 23:14 ` Jeremy Kerr 2013-11-22 7:07 ` Masahiro Yamada 2013-11-26 1:19 ` Masahiro Yamada 1 sibling, 1 reply; 5+ messages in thread From: Jeremy Kerr @ 2013-11-21 23:14 UTC (permalink / raw) To: u-boot Hi all, > On 11/21/2013 12:14 PM, Masahiro Yamada wrote: >> Hi. >> >> I posted a patch to change a file permission. >> This: >> http://lists.denx.de/pipermail/u-boot/2013-November/167573.html >> >> and again: >> http://lists.denx.de/pipermail/u-boot/2013-November/167608.html >> >> >> But my patch would not appear on patchwork. >> (Maybe because there is no diff line.) > > I think so too. There is some handling for renames without patch in > patchwork, but I think there is no handling for just file permission > changes. That should be fixed in patchwork then. Yep, that's correct - there's no support for these permission changes at present. I'll add that! Cheers, Jeremy ^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] patchwork does not pick my patch 2013-11-21 23:14 ` Jeremy Kerr @ 2013-11-22 7:07 ` Masahiro Yamada 0 siblings, 0 replies; 5+ messages in thread From: Masahiro Yamada @ 2013-11-22 7:07 UTC (permalink / raw) To: u-boot Hello Jeremy > >> But my patch would not appear on patchwork. > >> (Maybe because there is no diff line.) > > > > I think so too. There is some handling for renames without patch in > > patchwork, but I think there is no handling for just file permission > > changes. That should be fixed in patchwork then. > > Yep, that's correct - there's no support for these permission changes at > present. I'll add that! Thanks! BTW, I notice another issue of patchwork. Patchwork sometimes picks up emails which should not be. For example, I post an email (not a patch format, but includes some diff lines) to the ML: http://u-boot.10912.n7.nabble.com/RFC-ARM-optimized-memcpy-memset-on-SPL-build-td159583.html And it was shown up on patchwork against my will. http://patchwork.ozlabs.org/patch/260004/ I appreciate if you would fix this also. Best Regards Masahiro Yamada ^ permalink raw reply [flat|nested] 5+ messages in thread
* [U-Boot] patchwork does not pick my patch 2013-11-21 11:32 ` Andreas Bießmann 2013-11-21 23:14 ` Jeremy Kerr @ 2013-11-26 1:19 ` Masahiro Yamada 1 sibling, 0 replies; 5+ messages in thread From: Masahiro Yamada @ 2013-11-26 1:19 UTC (permalink / raw) To: u-boot Hello, Tom. > > I posted a patch to change a file permission. > > This: > > http://lists.denx.de/pipermail/u-boot/2013-November/167573.html > > > > and again: > > http://lists.denx.de/pipermail/u-boot/2013-November/167608.html > > > > > > But my patch would not appear on patchwork. > > (Maybe because there is no diff line.) > > I think so too. There is some handling for renames without patch in > patchwork, but I think there is no handling for just file permission > changes. That should be fixed in patchwork then. > > > > Is it better to squash it to another patch? > > Well to show it up in patchwork that could work. Since this change is > quite trivial I think it will also work if you just peak the relevant > custodian to pick this from the list. Could you pick my trivial patch directly from the ML? http://lists.denx.de/pipermail/u-boot/2013-November/167573.html Best Regards Masahiro Yamada ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-11-26 1:19 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-11-21 11:14 [U-Boot] patchwork does not pick my patch Masahiro Yamada 2013-11-21 11:32 ` Andreas Bießmann 2013-11-21 23:14 ` Jeremy Kerr 2013-11-22 7:07 ` Masahiro Yamada 2013-11-26 1:19 ` Masahiro Yamada
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox