public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] soft i2c behaviour on address not <ACK>ed
Date: Mon, 25 Nov 2013 08:46:06 +0100	[thread overview]
Message-ID: <5293003E.8070608@denx.de> (raw)
In-Reply-To: <E64115DDEB03174E9F77D3FC9D8DFEB506B703@srv214.gdsys.de>

Hello Dirk,

Am 21.11.2013 13:34, schrieb Eibach, Dirk:
> While debugging an I2C problem I found in soft_i2c_read() and
> soft_i2c_write():
>
> if(write_byte(addr>>  shift)) {
> 	PRINTD("i2c_read, address not<ACK>ed\n");
> 	return(1);
> }
>
> and
>
> if(write_byte(addr>>  shift)) {
> 	PRINTD("i2c_write, address not<ACK>ed\n");
> 	return(1);
> }
>
> This means that these functions are left without sending a STOP
> condition to the bus and with SCL held low. Is that really intended?

This seems a bug to me ... could you send a patch?

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

      reply	other threads:[~2013-11-25  7:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-21 12:34 [U-Boot] soft i2c behaviour on address not <ACK>ed Eibach, Dirk
2013-11-25  7:46 ` Heiko Schocher [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5293003E.8070608@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox