* [U-Boot] [PATCH v2] mpc85xx: Fix the offset of register address error
@ 2013-10-17 2:47 Yuantian.Tang at freescale.com
2013-11-25 21:02 ` York Sun
0 siblings, 1 reply; 2+ messages in thread
From: Yuantian.Tang at freescale.com @ 2013-10-17 2:47 UTC (permalink / raw)
To: u-boot
From: Tang Yuantian <yuantian.tang@freescale.com>
The offset of register address within GPIO module is just
CONFIG_SYS_MPC85xx_GPIO_ADDR. So, fix it. The following platforms
are confirmed: MPC8572, P1023, P1020, P1022, P2020, P4080,
P5020, P5040, T4240, B4860.
Signed-off-by: Tang Yuantian <Yuantian.Tang@freescale.com>
---
v2:
- updated the commit message.
arch/powerpc/include/asm/mpc85xx_gpio.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/include/asm/mpc85xx_gpio.h b/arch/powerpc/include/asm/mpc85xx_gpio.h
index 3d11884..87bb4a0 100644
--- a/arch/powerpc/include/asm/mpc85xx_gpio.h
+++ b/arch/powerpc/include/asm/mpc85xx_gpio.h
@@ -20,7 +20,7 @@
static inline void mpc85xx_gpio_set(unsigned int mask,
unsigned int dir, unsigned int val)
{
- ccsr_gpio_t *gpio = (void *)(CONFIG_SYS_MPC85xx_GPIO_ADDR + 0xc00);
+ ccsr_gpio_t *gpio = (void *)(CONFIG_SYS_MPC85xx_GPIO_ADDR);
/* First mask off the unwanted parts of "dir" and "val" */
dir &= mask;
@@ -56,7 +56,7 @@ static inline void mpc85xx_gpio_set_high(unsigned int gpios)
static inline unsigned int mpc85xx_gpio_get(unsigned int mask)
{
- ccsr_gpio_t *gpio = (void *)(CONFIG_SYS_MPC85xx_GPIO_ADDR + 0xc00);
+ ccsr_gpio_t *gpio = (void *)(CONFIG_SYS_MPC85xx_GPIO_ADDR);
/* Read the requested values */
return in_be32(&gpio->gpdat) & mask;
--
1.8.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [U-Boot] [PATCH v2] mpc85xx: Fix the offset of register address error
2013-10-17 2:47 [U-Boot] [PATCH v2] mpc85xx: Fix the offset of register address error Yuantian.Tang at freescale.com
@ 2013-11-25 21:02 ` York Sun
0 siblings, 0 replies; 2+ messages in thread
From: York Sun @ 2013-11-25 21:02 UTC (permalink / raw)
To: u-boot
On 10/16/2013 07:47 PM, Yuantian.Tang at freescale.com wrote:
> From: Tang Yuantian <yuantian.tang@freescale.com>
>
> The offset of register address within GPIO module is just
> CONFIG_SYS_MPC85xx_GPIO_ADDR. So, fix it. The following platforms
> are confirmed: MPC8572, P1023, P1020, P1022, P2020, P4080,
> P5020, P5040, T4240, B4860.
>
> Signed-off-by: Tang Yuantian <Yuantian.Tang@freescale.com>
> ---
Applied to u-boot-mpc85xx/master. Thanks.
York
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-11-25 21:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-17 2:47 [U-Boot] [PATCH v2] mpc85xx: Fix the offset of register address error Yuantian.Tang at freescale.com
2013-11-25 21:02 ` York Sun
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox