From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: tegra: Fix the CPU complex reset masks
Date: Mon, 25 Nov 2013 16:12:10 -0700 [thread overview]
Message-ID: <5293D94A.6020206@wwwdotorg.org> (raw)
In-Reply-To: <20131125115424.47113ae3@avionic-0020>
On 11/25/2013 03:54 AM, Alban Bedel wrote:
> On Thu, 21 Nov 2013 13:26:07 -0700
> Stephen Warren <swarren@wwwdotorg.org> wrote:
>
>> On 11/20/2013 09:42 AM, Alban Bedel wrote:
>>> The CPU complex reset masks are not matching with the datasheet for
>>> the CLK_RST_CONTROLLER_RST_CPU_CMPLX_SET/CLR_0 registers. For both T20
>>> and T30 the register consist of groups of 4 bits, with one bit for
>>> each CPU core. On T20 the 2 high bits of each group are always stubbed
>>> as there is only 2 cores.
>>
>> This looks correct to me. Given this problem, it's surprising that
>> reset_A9_cpu() was operating correctly, and that secondary CPUs were
>> coming out of reset OK later. What testing has this had (which SoCs and
>> boards)?
>
> I only tested it on T30 using our Tamonten NG board.
OK, I tested on all Tegra SoCs, and everything (including a CPU hotplug
test in a kernel once booted with the new U-Boot) still works, so,
Tested-by: Stephen Warren <swrren@nvidia.com>
prev parent reply other threads:[~2013-11-25 23:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-20 16:42 [U-Boot] [PATCH] arm: tegra: Fix the CPU complex reset masks Alban Bedel
2013-11-21 20:26 ` Stephen Warren
2013-11-25 10:54 ` Alban Bedel
2013-11-25 23:12 ` Stephen Warren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5293D94A.6020206@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox