From: Andre Przywara <andre.przywara@linaro.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/9] ARM: HYP/non-sec: move switch to non-sec to the last boot phase
Date: Tue, 26 Nov 2013 15:36:53 +0100 [thread overview]
Message-ID: <5294B205.2020604@linaro.org> (raw)
In-Reply-To: <1385024402-23585-3-git-send-email-marc.zyngier@arm.com>
On 11/21/2013 09:59 AM, Marc Zyngier wrote:
> Having the switch to non-secure in the "prep" phase is causing
> all kind of troubles, as that stage can be called multiple times.
>
> Instead, move the switch to non-secure to the last possible phase,
> when there is no turning back anymore.
Tested on Versatile Express TC2.
Albert, Tom: please apply for v2014.01.
Acked-by: Andre Przywara <andre.przywara@linaro.org>
>
> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
> ---
> arch/arm/lib/bootm.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/lib/bootm.c b/arch/arm/lib/bootm.c
> index f476a89..f3da634 100644
> --- a/arch/arm/lib/bootm.c
> +++ b/arch/arm/lib/bootm.c
> @@ -234,7 +234,6 @@ static void boot_prep_linux(bootm_headers_t *images)
> printf("FDT and ATAGS support not compiled in - hanging\n");
> hang();
> }
> - do_nonsec_virt_switch();
> }
>
> /* Subcommand: GO */
> @@ -264,8 +263,10 @@ static void boot_jump_linux(bootm_headers_t *images, int flag)
> else
> r2 = gd->bd->bi_boot_params;
>
> - if (!fake)
> + if (!fake) {
> + do_nonsec_virt_switch();
> kernel_entry(0, machid, r2);
> + }
> }
>
> /* Main Entry point for arm bootm implementation
>
next prev parent reply other threads:[~2013-11-26 14:36 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-21 8:59 [U-Boot] [PATCH 0/9] ARMv7: add PSCI support to u-boot Marc Zyngier
2013-11-21 8:59 ` [U-Boot] [PATCH 1/9] ARM: HYP/non-sec: fix alignment requirements for vectors Marc Zyngier
2013-11-21 10:19 ` Masahiro Yamada
2013-11-21 10:36 ` Marc Zyngier
2013-11-21 22:24 ` Andre Przywara
2013-11-21 8:59 ` [U-Boot] [PATCH 2/9] ARM: HYP/non-sec: move switch to non-sec to the last boot phase Marc Zyngier
2013-11-26 14:36 ` Andre Przywara [this message]
2013-11-21 8:59 ` [U-Boot] [PATCH 3/9] ARM: HYP/non-sec: add a barrier after setting SCR.NS==1 Marc Zyngier
2013-11-22 1:51 ` Christoffer Dall
2013-11-22 10:56 ` Marc Zyngier
2013-11-22 16:53 ` Christoffer Dall
2013-12-30 3:10 ` [U-Boot] [PATCH 3/9] ARM: HYP/non-sec switch in bootm.c TigerLiu at viatech.com.cn
2013-12-30 4:57 ` Christoffer Dall
2013-12-30 5:15 ` TigerLiu at viatech.com.cn
2013-12-30 5:22 ` Christoffer Dall
2013-12-30 5:33 ` TigerLiu at viatech.com.cn
2013-11-26 14:39 ` [U-Boot] [PATCH 3/9] ARM: HYP/non-sec: add a barrier after setting SCR.NS==1 Andre Przywara
2013-11-21 8:59 ` [U-Boot] [PATCH 4/9] ARM: non-sec: reset CNTVOFF to zero Marc Zyngier
2013-11-26 14:41 ` Andre Przywara
2013-11-26 14:46 ` Marc Zyngier
2013-11-21 8:59 ` [U-Boot] [PATCH 5/9] ARM: HYP/non-sec: add generic ARMv7 PSCI code Marc Zyngier
2013-11-21 8:59 ` [U-Boot] [PATCH 6/9] ARM: HYP/non-sec: make pen code sections depend on !ARMV7_PSCI Marc Zyngier
2014-06-04 1:51 ` [U-Boot] [PATCH 6/9] ARM: HYP/non-sec: make pen code sectionsdepend " TigerLiu at via-alliance.com
2013-11-21 9:00 ` [U-Boot] [PATCH 7/9] ARM: HYP/non-sec: add the option for a second-stage monitor Marc Zyngier
2013-11-21 9:00 ` [U-Boot] [PATCH 8/9] sunxi: HYP/non-sec: add sun7i PSCI backend Marc Zyngier
2013-11-21 9:00 ` [U-Boot] [PATCH 9/9] sunxi: HYP/non-sec: configure CNTFRQ on all CPUs Marc Zyngier
2013-11-21 14:28 ` [U-Boot] [PATCH 0/9] ARMv7: add PSCI support to u-boot Rob Herring
2013-11-21 15:04 ` Marc Zyngier
2013-11-22 1:54 ` Christoffer Dall
2013-11-22 3:58 ` Anup Patel
2013-11-22 8:42 ` [U-Boot] [linux-sunxi] " Ian Campbell
2013-11-22 9:00 ` Anup Patel
2013-11-22 16:49 ` Christoffer Dall
2013-11-22 10:25 ` [U-Boot] " Marc Zyngier
2013-11-22 10:51 ` Marc Zyngier
2013-11-22 8:40 ` [U-Boot] [linux-sunxi] " Ian Campbell
2013-11-22 8:56 ` Anup Patel
2013-11-22 10:49 ` Ian Campbell
2013-11-22 14:51 ` Marc Zyngier
2013-12-06 11:43 ` [U-Boot] " Andre Przywara
2013-12-06 12:12 ` Marc Zyngier
2013-12-06 12:59 ` [U-Boot] [linux-sunxi] " Ian Campbell
2013-12-06 15:44 ` Ian Campbell
2013-12-06 15:48 ` Andre Przywara
2013-12-06 17:21 ` Ian Campbell
2013-12-06 17:45 ` Marc Zyngier
2013-12-06 13:03 ` [U-Boot] " Andre Przywara
2013-12-06 16:00 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5294B205.2020604@linaro.org \
--to=andre.przywara@linaro.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox