From: "Benoît Thébaudeau" <benoit.thebaudeau@advansee.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] armv7: Move save_boot_params_default() to start.S
Date: Sat, 11 Aug 2012 01:12:28 +0200 (CEST) [thread overview]
Message-ID: <529590157.2285192.1344640348634.JavaMail.root@advansee.com> (raw)
In-Reply-To: <20120810224434.GH3306@bill-the-cat>
On Sat, Aug 11, 2012 at 12:44:34 AM +0200, Tom Rini wrote:
> On Fri, Aug 10, 2012 at 11:59:09PM +0200, Beno?t Th?baudeau wrote:
>
> > save_boot_params() is called by start.S, so move its default
> > implementation to
> > this file too. This is also useful for boards willing to use
> > nand_spl since
> > cpu.c is not built in this case.
> >
> > Signed-off-by: Beno?t Th?baudeau <benoit.thebaudeau@advansee.com>
> > Cc: Albert Aribaud <albert.u.boot@aribaud.net>
>
> We should pick up http://patchwork.ozlabs.org/patch/169561/ instead
> as
> yours is missing START/ENDPROC
Yes.
> and doesn't just declare the initial
> implementation weak.
What do you mean? It does:
+.weak save_boot_params
One version or the other, I don't care as long as one of them is applied. Why
has Tetsuyuki's patch still not been applied? You've ack'ed it on 7/9.
Best regards,
Beno?t
next prev parent reply other threads:[~2012-08-10 23:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-10 21:59 [U-Boot] [PATCH] armv7: Move save_boot_params_default() to start.S Benoît Thébaudeau
2012-08-10 22:44 ` Tom Rini
2012-08-10 23:12 ` Benoît Thébaudeau [this message]
2012-08-11 0:42 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529590157.2285192.1344640348634.JavaMail.root@advansee.com \
--to=benoit.thebaudeau@advansee.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox