From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?utf-8?Q?Beno=C3=AEt_Th=C3=A9baudeau?= <benoit.thebaudeau@advansee.com>
Date: Sat, 11 Aug 2012 01:12:28 +0200 (CEST)
Subject: [U-Boot] [PATCH] armv7: Move save_boot_params_default() to
 start.S
In-Reply-To: <20120810224434.GH3306@bill-the-cat>
Message-ID: <529590157.2285192.1344640348634.JavaMail.root@advansee.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Sat, Aug 11, 2012 at 12:44:34 AM +0200, Tom Rini wrote:
> On Fri, Aug 10, 2012 at 11:59:09PM +0200, Beno?t Th?baudeau wrote:
> 
> > save_boot_params() is called by start.S, so move its default
> > implementation to
> > this file too. This is also useful for boards willing to use
> > nand_spl since
> > cpu.c is not built in this case.
> > 
> > Signed-off-by: Beno?t Th?baudeau <benoit.thebaudeau@advansee.com>
> > Cc: Albert Aribaud <albert.u.boot@aribaud.net>
> 
> We should pick up http://patchwork.ozlabs.org/patch/169561/ instead
> as
> yours is missing START/ENDPROC

Yes.

> and doesn't just declare the initial
> implementation weak.

What do you mean? It does:
+.weak save_boot_params

One version or the other, I don't care as long as one of them is applied. Why
has Tetsuyuki's patch still not been applied? You've ack'ed it on 7/9.

Best regards,
Beno?t