[U-Boot] OMAP3 i2c issues on IGEP, u-boot 2013.10

Thomas Petazzoni
2013-11-27T16:10:26Z

Dear Nikita Kiryanov,

On Wed, 27 Nov 2013 17:52:31 +0200, Nikita Kiryanov wrote:

> The zeroing of the cnt register also happens in other places in the
> driver, and it is entirely possible that they should be removed for
> OMAP3s as well.
>
> In my patch I removed it only for i2c_write() because the original
> driver also zeroed the cnt register in I/O functions- except in
> i2c_write(), and I decided to follow the original driver's lead.
>
> What happens if you remove all the lines that zero the cnt register?

It works. I've removed all the writew(0, ...cnt register...), and then
I've done at least 20 boots of the IGEP board, and all of them were
successful.

I've attached the ugly patch that comments out all of those cases. Of
course, it's not a patch intended for merging, just to show which
locations I've commented.

Since I've absolutely no idea of the background for the problem, would
you mind submitting a proper patch with a good explanation? I will be
happy to test it, of course.

Thanks!

Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: omap3-fix-i2c.patch
Type: text/x-patch
Size: 1333 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20131127/1ac73095/attachment.bin>