From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nikita Kiryanov Date: Wed, 27 Nov 2013 18:31:07 +0200 Subject: [U-Boot] OMAP3 i2c issues on IGEP, u-boot 2013.10 In-Reply-To: <20131127171026.237fc859@skate> References: <20131127131929.34505e23@skate> <20131127151121.51f124e6@skate> <52960748.4020203@compulab.co.il> <20131127162839.0b7f65c3@skate> <5296153F.9040006@compulab.co.il> <20131127171026.237fc859@skate> Message-ID: <52961E4B.5020705@compulab.co.il> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 11/27/2013 06:10 PM, Thomas Petazzoni wrote: > Dear Nikita Kiryanov, > > On Wed, 27 Nov 2013 17:52:31 +0200, Nikita Kiryanov wrote: > >> The zeroing of the cnt register also happens in other places in the >> driver, and it is entirely possible that they should be removed for >> OMAP3s as well. >> >> In my patch I removed it only for i2c_write() because the original >> driver also zeroed the cnt register in I/O functions- except in >> i2c_write(), and I decided to follow the original driver's lead. >> >> What happens if you remove all the lines that zero the cnt register? > > It works. I've removed all the writew(0, ...cnt register...), and then > I've done at least 20 boots of the IGEP board, and all of them were > successful. > > I've attached the ugly patch that comments out all of those cases. Of > course, it's not a patch intended for merging, just to show which > locations I've commented. > > Since I've absolutely no idea of the background for the problem, would > you mind submitting a proper patch with a good explanation? I will be > happy to test it, of course. Sure. I'm about to leave office though, so I'll prepare it tomorrow. > > Thanks! > > Thomas > -- Regards, Nikita.