From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jaehoon Chung Date: Fri, 29 Nov 2013 19:05:21 +0900 Subject: [U-Boot] [PATCH] dwmmc: make driver usable for non-exynos platforms In-Reply-To: <1385719363.2810.49.camel@abrodkin-8560l.internal.synopsys.com> References: <1385646735-8726-1-git-send-email-abrodkin@synopsys.com> <52980E0F.7030403@samsung.com> <1385710904.2810.20.camel@abrodkin-8560l.internal.synopsys.com> <529864F9.9000007@samsung.com> <1385719363.2810.49.camel@abrodkin-8560l.internal.synopsys.com> Message-ID: <529866E1.4030808@samsung.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 11/29/2013 07:02 PM, Alexey Brodkin wrote: > On Fri, 2013-11-29 at 18:57 +0900, Jaehoon Chung wrote: >> I think good that just removed the "#include ". >> Instead, Exnyos specific code can move into dw-mmc-exynos.c with callback function. >> (I didn't know whcih Soc is used with MPSCTRL register.) >> >>> Because of this you selected this offset "0x9c" and experience no >>> problems. But at some point you may get HW configured to use 64-bit >>> addressing and you'll need to use another offset for Exynos-specific >>> things. I understand that as SW engineer you have not much things to do >>> here but would be good if you communicate this to HW engineers. >> If other soc is used 0x9c offset as other register? >> 0x9c is used the CLKSEL at exynos. we need to consider other soc. >> Then it's good that exynos specific code will move into dw-mmc-exynos.c. isn't? > > Ok, so please look at my re-spin I already sent (you were on CC-list). > There I only mask problematic bits of code - so driver works again for > me (I'm on other architecture BTW - not ARM). > > But if you're willing to clean-up dwmmc code from Exynos-specific parts > I'll be more than happy. I will work to clean-up dwmmc code from exynos specific code. And will send patch. Thanks for reporting this point. Best Regards, Jaehoon Chung > > Well it doesn't stop us from application of my v2 that will be a > temporary fix until clean-up. > > -Alexey > > > _______________________________________________ > U-Boot mailing list > U-Boot at lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot >