public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Eric Nelson <eric.nelson@boundarydevices.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 5/5] ARM: mx6: Enable PCIe on Sabrelite
Date: Mon, 02 Dec 2013 18:05:24 -0700	[thread overview]
Message-ID: <529D2E54.3000104@boundarydevices.com> (raw)
In-Reply-To: <201311300106.02184.marex@denx.de>

Hi Marek,

On 11/29/2013 05:06 PM, Marek Vasut wrote:
> Dear Stefano Babic,
>
>> Hi Eric, Marek,
>>
>> On 27/11/2013 17:19, Eric Nelson wrote:
>>> It seems to lock up the system if you don't have the proper
>>> device connected.
>>>
>>> Without this bit, I was able to confirm proper enumeration
>>>
>>> of a PCIe bus with a USB 3.0 controller:
>>>     00:01.0     - 16c3:abcd - Bridge device
>>>     01:00.0    - 1b21:0612 - Mass storage controller
>>>
>>> Unfortunately, in a quick test, the image fails to boot
>>> without a PCIe device connected, or oddly, with a different
>>> PCIe ethernet controller connected.
>>>
>>> I think it's handy to have the placeholder here, but
>>> I think you're the only person on the planet with the
>>> right set of components to make it work at the moment.
>>
>> Waiting for someone from Mars is coming to help Marek, I'll put the
>> patchset in the -next for better testing.
>
> I got a hint from fourth dimension, let's see if the patch I produced in a
> higher level of consciousness helps ... let's hope I wasn't too high (pun
> intended, lol!)
>

Sorry for the delayed response. The holiday got in the way
of testing.

I think I already had this patch. I tested with these
patches against Stefano's master branch:

0001-ARM-mx6-Update-non-Freescale-boards-to-include-CPU-e.patch
0002-ARM-armv7-Make-indirect-vector-addresses-globl.patch
0003-ARM-lib-Add-cpu_clock_teardown-call.patch
0004-ARM-mx6-Add-PCI-express-clock-configuration.patch
0005-ARM-mx6-Add-PCI-express-driver.patch
0006-ARM-mx6-Enable-PCIe-on-Sabrelite.patch

I also apologize for some bad information the other day.

I saw (and reported) lock-ups during PCIE bus enumeration,
but I can't seem to reproduce them tonight.

I've tested against three different PCIe devices, and with
nothing connected, and everything boots.

As I mentioned, we don't have one of the ethernet
adapters you're using, but this patch set doesn't appear to
break anything.

I'll try on some other boards over the coming days and
let you know if I see any issues.

Regards,


Eric

  reply	other threads:[~2013-12-03  1:05 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-11 16:22 [U-Boot] [PATCH 1/5] ARM: armv7: Make indirect vector addresses globl Marek Vasut
2013-11-11 16:22 ` [U-Boot] [PATCH 2/5] ARM: lib: Add cpu_clock_teardown() call Marek Vasut
2013-11-27  8:44   ` Stefano Babic
2013-11-27  8:59     ` Marek Vasut
2013-11-27  9:24       ` Stefano Babic
2013-11-11 16:22 ` [U-Boot] [PATCH 3/5] ARM: mx6: Add PCI express clock configuration Marek Vasut
2013-11-27  8:45   ` Stefano Babic
2013-11-11 16:22 ` [U-Boot] [PATCH 4/5] ARM: mx6: Add PCI express driver Marek Vasut
2013-11-27  8:45   ` Stefano Babic
2013-11-11 16:22 ` [U-Boot] [PATCH 5/5] ARM: mx6: Enable PCIe on Sabrelite Marek Vasut
2013-11-27  8:45   ` Stefano Babic
2013-11-27  8:59     ` Marek Vasut
2013-11-27 14:03       ` Eric Nelson
2013-11-27 15:02         ` Marek Vasut
2013-11-27 16:19   ` Eric Nelson
2013-11-28  8:20     ` Stefano Babic
2013-11-30  0:06       ` Marek Vasut
2013-12-03  1:05         ` Eric Nelson [this message]
2013-12-03  8:12           ` Stefano Babic
2013-12-03  9:12             ` Marek Vasut
2013-12-03 10:21               ` Stefano Babic
2013-12-03 12:31                 ` Marek Vasut
2013-12-03  9:12           ` Marek Vasut
2013-11-30  0:03     ` Marek Vasut
2013-11-11 16:24 ` [U-Boot] [PATCH 1/5] ARM: armv7: Make indirect vector addresses globl Marek Vasut
2013-11-27  8:44 ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=529D2E54.3000104@boundarydevices.com \
    --to=eric.nelson@boundarydevices.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox