From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Nelson <eric.nelson@boundarydevices.com>
Date: Mon, 02 Dec 2013 18:05:24 -0700
Subject: [U-Boot] [PATCH 5/5] ARM: mx6: Enable PCIe on Sabrelite
In-Reply-To: <201311300106.02184.marex@denx.de>
References: <1384186966-6054-1-git-send-email-marex@denx.de>
	<52961B8D.5070205@boundarydevices.com>
	<5296FCC6.8020802@denx.de> <201311300106.02184.marex@denx.de>
Message-ID: <529D2E54.3000104@boundarydevices.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Marek,

On 11/29/2013 05:06 PM, Marek Vasut wrote:
> Dear Stefano Babic,
>
>> Hi Eric, Marek,
>>
>> On 27/11/2013 17:19, Eric Nelson wrote:
>>> It seems to lock up the system if you don't have the proper
>>> device connected.
>>>
>>> Without this bit, I was able to confirm proper enumeration
>>>
>>> of a PCIe bus with a USB 3.0 controller:
>>>     00:01.0     - 16c3:abcd - Bridge device
>>>     01:00.0    - 1b21:0612 - Mass storage controller
>>>
>>> Unfortunately, in a quick test, the image fails to boot
>>> without a PCIe device connected, or oddly, with a different
>>> PCIe ethernet controller connected.
>>>
>>> I think it's handy to have the placeholder here, but
>>> I think you're the only person on the planet with the
>>> right set of components to make it work at the moment.
>>
>> Waiting for someone from Mars is coming to help Marek, I'll put the
>> patchset in the -next for better testing.
>
> I got a hint from fourth dimension, let's see if the patch I produced in a
> higher level of consciousness helps ... let's hope I wasn't too high (pun
> intended, lol!)
>

Sorry for the delayed response. The holiday got in the way
of testing.

I think I already had this patch. I tested with these
patches against Stefano's master branch:

0001-ARM-mx6-Update-non-Freescale-boards-to-include-CPU-e.patch
0002-ARM-armv7-Make-indirect-vector-addresses-globl.patch
0003-ARM-lib-Add-cpu_clock_teardown-call.patch
0004-ARM-mx6-Add-PCI-express-clock-configuration.patch
0005-ARM-mx6-Add-PCI-express-driver.patch
0006-ARM-mx6-Enable-PCIe-on-Sabrelite.patch

I also apologize for some bad information the other day.

I saw (and reported) lock-ups during PCIE bus enumeration,
but I can't seem to reproduce them tonight.

I've tested against three different PCIe devices, and with
nothing connected, and everything boots.

As I mentioned, we don't have one of the ethernet
adapters you're using, but this patch set doesn't appear to
break anything.

I'll try on some other boards over the coming days and
let you know if I see any issues.

Regards,


Eric