From: Troy Kisky <troy.kisky@boundarydevices.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mx6: clock: Fix the calculation of PLL_ENET frequency
Date: Tue, 03 Dec 2013 13:15:50 -0700 [thread overview]
Message-ID: <529E3BF6.9040709@boundarydevices.com> (raw)
In-Reply-To: <1386100561-8137-1-git-send-email-festevam@gmail.com>
On 12/3/2013 12:56 PM, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> According to the mx6 quad reference manual, the DIV_SELECT field of register
> CCM_ANALOG_PLL_ENETn has the following meaning:
>
> "Controls the frequency of the ethernet reference clock.
> - 00 - 25MHz
> - 01 - 50MHz
> - 10 - 100MHz
> - 11 - 125MHz"
>
> Current logic does not handle the 25MHz case correctly, so fix it.
>
> Signed-off-by: Rabeeh Khoury <rabeeh@solid-run.com>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> arch/arm/cpu/armv7/mx6/clock.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/cpu/armv7/mx6/clock.c b/arch/arm/cpu/armv7/mx6/clock.c
> index 873d9d0..eab8596 100644
> --- a/arch/arm/cpu/armv7/mx6/clock.c
> +++ b/arch/arm/cpu/armv7/mx6/clock.c
> @@ -94,7 +94,10 @@ static u32 decode_pll(enum pll_clocks pll, u32 infreq)
> div = __raw_readl(&imx_ccm->analog_pll_enet);
> div &= BM_ANADIG_PLL_ENET_DIV_SELECT;
>
> - return (div == 3 ? 125000000 : 25000000 * (div << 1));
> + if (div == 0)
> + return 25000000;
> + else
> + return (div == 3 ? 125000000 : 25000000 * (div << 1));
> default:
> return 0;
> }
How about just
return 25000000 * (div + (div >> 1) + 1);
next prev parent reply other threads:[~2013-12-03 20:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-03 19:56 [U-Boot] [PATCH] mx6: clock: Fix the calculation of PLL_ENET frequency Fabio Estevam
2013-12-03 20:15 ` Troy Kisky [this message]
2013-12-03 20:29 ` Fabio Estevam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=529E3BF6.9040709@boundarydevices.com \
--to=troy.kisky@boundarydevices.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox