[U-Boot] [PATCH 1/2] mx6sabresd: Allow probing HYNC, VSYNC and DISP_CLK signals

[U-Boot] [PATCH 1/2] mx6sabresd: Allow probing HYNC, VSYNC and DISP_CLK signals

[Fabio Estevam]

HSYNC, VSYNC and DISP_CLK are very useful display signals for debugging.

Configure them as active pins.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 board/freescale/mx6sabresd/mx6sabresd.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/board/freescale/mx6sabresd/mx6sabresd.c b/board/freescale/mx6sabresd/mx6sabresd.c
index 7e5bdf7..7b8db08 100644
--- a/board/freescale/mx6sabresd/mx6sabresd.c
+++ b/board/freescale/mx6sabresd/mx6sabresd.c
@@ -120,6 +120,12 @@ iomux_v3_cfg_t const usdhc4_pads[] = {
 	MX6_PAD_SD4_DAT7__SD4_DATA7 | MUX_PAD_CTRL(USDHC_PAD_CTRL),
 };
 
+iomux_v3_cfg_t const di0_pads[] = {
+	MX6_PAD_DI0_DISP_CLK__IPU1_DI0_DISP_CLK,	/* DISP0_CLK */
+	MX6_PAD_DI0_PIN2__IPU1_DI0_PIN02,		/* DISP0_HSYNC */
+	MX6_PAD_DI0_PIN3__IPU1_DI0_PIN03,		/* DISP0_VSYNC */
+};
+
 static void setup_iomux_uart(void)
 {
 	imx_iomux_v3_setup_multiple_pads(uart1_pads, ARRAY_SIZE(uart1_pads));
@@ -371,6 +377,8 @@ static void setup_display(void)
 	struct iomuxc *iomux = (struct iomuxc *)IOMUXC_BASE_ADDR;
 	int reg;
 
+	imx_iomux_v3_setup_multiple_pads(di0_pads, ARRAY_SIZE(di0_pads));
+
 	enable_ipu_clock();
 	imx_setup_hdmi();
 
-- 
1.8.1.2

[U-Boot] [PATCH 2/2] mx6sabresd: Fix LVDS width and color format

[Fabio Estevam]

mx6sabresd boards have a 18-bit LVDS data width and the correct color format
is RGB666.

Suggested-by: Liu Ying <Ying.Liu@freescale.com>
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 board/freescale/mx6sabresd/mx6sabresd.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/board/freescale/mx6sabresd/mx6sabresd.c b/board/freescale/mx6sabresd/mx6sabresd.c
index 7b8db08..71eabdb 100644
--- a/board/freescale/mx6sabresd/mx6sabresd.c
+++ b/board/freescale/mx6sabresd/mx6sabresd.c
@@ -279,15 +279,15 @@ static void enable_lvds(struct display_info_t const *dev)
 	struct iomuxc *iomux = (struct iomuxc *)
 				IOMUXC_BASE_ADDR;
 	u32 reg = readl(&iomux->gpr[2]);
-	reg |= IOMUXC_GPR2_DATA_WIDTH_CH0_24BIT |
-	       IOMUXC_GPR2_DATA_WIDTH_CH1_24BIT;
+	reg |= IOMUXC_GPR2_DATA_WIDTH_CH0_18BIT |
+	       IOMUXC_GPR2_DATA_WIDTH_CH1_18BIT;
 	writel(reg, &iomux->gpr[2]);
 }
 
 static struct display_info_t const displays[] = {{
 	.bus	= -1,
 	.addr	= 0,
-	.pixfmt	= IPU_PIX_FMT_LVDS666,
+	.pixfmt	= IPU_PIX_FMT_RGB666,
 	.detect	= NULL,
 	.enable	= enable_lvds,
 	.mode	= {
-- 
1.8.1.2

[U-Boot] [PATCH 1/2] mx6sabresd: Allow probing HYNC, VSYNC and DISP_CLK signals

[Otavio Salvador]

On Tue, Dec 3, 2013 at 2:19 PM, Fabio Estevam
<fabio.estevam@freescale.com> wrote:
> HSYNC, VSYNC and DISP_CLK are very useful display signals for debugging.
>
> Configure them as active pins.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
...
> +       imx_iomux_v3_setup_multiple_pads(di0_pads, ARRAY_SIZE(di0_pads));

A single line comment here making it clear it is here for convenience
would be good.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

[U-Boot] [PATCH 1/2] mx6sabresd: Allow probing HYNC, VSYNC and DISP_CLK signals

[Liu Ying]

On 12/04/2013 12:19 AM, Fabio Estevam wrote:
> HSYNC, VSYNC and DISP_CLK are very useful display signals for debugging.
> 
> Configure them as active pins.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  board/freescale/mx6sabresd/mx6sabresd.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 

Please fix the typo 'HYNC' in the commit head. It should be 'HSYNC'.

Regard,
Liu Ying