* [U-Boot] [PATCH] PowerPC: mpc83xx: Do not use absolute paths for obj-y
@ 2013-12-03 6:45 Masahiro Yamada
2013-12-04 9:21 ` Masahiro Yamada
0 siblings, 1 reply; 3+ messages in thread
From: Masahiro Yamada @ 2013-12-03 6:45 UTC (permalink / raw)
To: u-boot
Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
---
Please make sure relative paths always should be used
when $(obj-y) points to objects under a different directory.
The absolute path like follows:
obj-$(CONFIG_MPC8349) += $(SRCTREE)/drivers/ddr/fsl/mpc85xx_ddr_gen2.o
creates an object file under a strange path for out-of-tree build.
$ rm -rf build/
$ make O=build MPC8349EMDS_config
Configuring for MPC8349EMDS board...
$ make O=build CROSS_COMPILE=powerpc-linux-
<<snip>>
$ find . -name mpc85xx_ddr_gen2.o
./build/arch/powerpc/cpu/mpc83xx/home/yamada/workspace/u-boot/drivers/ddr/fsl/mpc85xx_ddr_gen2.o
arch/powerpc/cpu/mpc83xx/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/cpu/mpc83xx/Makefile b/arch/powerpc/cpu/mpc83xx/Makefile
index c345dd6..d184c04 100644
--- a/arch/powerpc/cpu/mpc83xx/Makefile
+++ b/arch/powerpc/cpu/mpc83xx/Makefile
@@ -39,7 +39,7 @@ obj-$(CONFIG_OF_LIBFDT) += fdt.o
obj-y += cache.o
ifdef CONFIG_SYS_FSL_DDR2
-obj-$(CONFIG_MPC8349) += $(SRCTREE)/drivers/ddr/fsl/mpc85xx_ddr_gen2.o
+obj-$(CONFIG_MPC8349) += ../../../../drivers/ddr/fsl/mpc85xx_ddr_gen2.o
else
obj-y += spd_sdram.o
endif
--
1.8.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] PowerPC: mpc83xx: Do not use absolute paths for obj-y
2013-12-03 6:45 [U-Boot] [PATCH] PowerPC: mpc83xx: Do not use absolute paths for obj-y Masahiro Yamada
@ 2013-12-04 9:21 ` Masahiro Yamada
2013-12-04 12:54 ` Tom Rini
0 siblings, 1 reply; 3+ messages in thread
From: Masahiro Yamada @ 2013-12-04 9:21 UTC (permalink / raw)
To: u-boot
Hi.
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> ---
>
> Please make sure relative paths always should be used
> when $(obj-y) points to objects under a different directory.
>
> The absolute path like follows:
> obj-$(CONFIG_MPC8349) += $(SRCTREE)/drivers/ddr/fsl/mpc85xx_ddr_gen2.o
> creates an object file under a strange path for out-of-tree build.
>
> $ rm -rf build/
> $ make O=build MPC8349EMDS_config
> Configuring for MPC8349EMDS board...
> $ make O=build CROSS_COMPILE=powerpc-linux-
> <<snip>>
> $ find . -name mpc85xx_ddr_gen2.o
> ./build/arch/powerpc/cpu/mpc83xx/home/yamada/workspace/u-boot/drivers/ddr/fsl/mpc85xx_ddr_gen2.o
Please change the status of this patch to Superseded or Rejected.
This patch was replaced with York Sun's patch:
http://patchwork.ozlabs.org/patch/296307/
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] PowerPC: mpc83xx: Do not use absolute paths for obj-y
2013-12-04 9:21 ` Masahiro Yamada
@ 2013-12-04 12:54 ` Tom Rini
0 siblings, 0 replies; 3+ messages in thread
From: Tom Rini @ 2013-12-04 12:54 UTC (permalink / raw)
To: u-boot
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 12/04/2013 04:21 AM, Masahiro Yamada wrote:
> Hi.
>
>
>> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
>> ---
>>
>> Please make sure relative paths always should be used
>> when $(obj-y) points to objects under a different directory.
>>
>> The absolute path like follows:
>> obj-$(CONFIG_MPC8349) += $(SRCTREE)/drivers/ddr/fsl/mpc85xx_ddr_gen2.o
>> creates an object file under a strange path for out-of-tree build.
>>
>> $ rm -rf build/
>> $ make O=build MPC8349EMDS_config
>> Configuring for MPC8349EMDS board...
>> $ make O=build CROSS_COMPILE=powerpc-linux-
>> <<snip>>
>> $ find . -name mpc85xx_ddr_gen2.o
>> ./build/arch/powerpc/cpu/mpc83xx/home/yamada/workspace/u-boot/drivers/ddr/fsl/mpc85xx_ddr_gen2.o
>
> Please change the status of this patch to Superseded or Rejected.
>
> This patch was replaced with York Sun's patch:
> http://patchwork.ozlabs.org/patch/296307/
Done, thanks.
- --
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQIcBAEBAgAGBQJSnyX5AAoJENk4IS6UOR1WSygP/3cw1pWU25rcIr3SnjHr2UEA
FTX213Gw+FJSl3IZUnylvL6zFmOOxn7D6Shf8/Nz7LbO2rZs/6jg5Ev/0XSvR/p3
SZmFsH/8ymEgjsiE5V0wMtexdWM0qXVbs9XKhM9VIEBeYnxS30f+u8ppw2Pq9qPF
6dhOaYDytVPbxb1cWWdroEFyJgu4lcwN/Rwbi+cgKX0m2m5nMOhdUUr/QvQYrOjy
PSv+pfv3GauEBus66SS3NZWzqpt48njtetfy5LeDNkCi1TwcAuKq1EPGP5Qy8qxZ
sEJR65iJfza3RjIahEYdhAd8mqtapm1zZ3ZAk8R0vca+/sW1eeA1xLYruJ4TPF5u
0bbW9DkVuhgwWwzRj1cQrV1MqdHU0562ysRST6iMUh5NqyawZ+PgQ2jW55Ti54gf
Nh+og5YRRSlDZtqqeF9QxjJgua8ziH8Daes3WkvNUaWgoU90Y4yZTKri+1q1UHCF
PH8wZbW4CEgXdrGW6o0W7DVE3PgoOalJzWxL8mbh40Mm2eQIG4XvS73IBkxnClGn
Hv/rPJNpKk1TSvEAZdk/g0aT2BzP3ISyXAJs4OiQrvbAc7D0MPRQ+936OSZsjwZ1
E124RMYebi8tUxHvIZ41IvxdgvjKIbmKqq3be8U1RQZSm3qyOwMKrhCNSxITYFoG
oDNlHCA2hN+lKdjCa4/+
=BuiJ
-----END PGP SIGNATURE-----
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-12-04 12:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-03 6:45 [U-Boot] [PATCH] PowerPC: mpc83xx: Do not use absolute paths for obj-y Masahiro Yamada
2013-12-04 9:21 ` Masahiro Yamada
2013-12-04 12:54 ` Tom Rini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox