From: Minkyu Kang <mk7.kang@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: exynos: adds ifdef for spi boot
Date: Fri, 06 Dec 2013 19:45:59 +0900 [thread overview]
Message-ID: <52A1AAE7.7060805@samsung.com> (raw)
In-Reply-To: <52A1A618.20807@samsung.com>
On 06/12/13 19:25, Minkyu Kang wrote:
> This patch fix following errors and warnings
>
> spl_boot.c: In function 'exynos_spi_copy':
> spl_boot.c:111:49: error: 'CONFIG_ENV_SPI_BASE' undeclared (first use in this function)
> spl_boot.c:111:49: note: each undeclared identifier is reported only once for each function it appears in
> spl_boot.c:142:2: error: 'SPI_FLASH_UBOOT_POS' undeclared (first use in this function)
> spl_boot.c: In function 'copy_uboot_to_ram':
> spl_boot.c:189:28: warning: unused variable 'param' [-Wunused-variable]
> spl_boot.c: At top level:
> spl_boot.c:107:13: warning: 'exynos_spi_copy' defined but not used [-Wunused-function]
>
> Signed-off-by: Minkyu Kang <mk7.kang@samsung.com>
> Cc: Albert ARIBAUD <albert.u.boot@aribaud.net>
> ---
> arch/arm/cpu/armv7/exynos/spl_boot.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/cpu/armv7/exynos/spl_boot.c b/arch/arm/cpu/armv7/exynos/spl_boot.c
> index 6faf13f..ade45fd 100644
> --- a/arch/arm/cpu/armv7/exynos/spl_boot.c
> +++ b/arch/arm/cpu/armv7/exynos/spl_boot.c
> @@ -62,6 +62,7 @@ static int config_branch_prediction(int set_cr_z)
> }
> #endif
>
> +#ifdef CONFIG_SPI_BOOTING
> static void spi_rx_tx(struct exynos_spi *regs, int todo,
> void *dinp, void const *doutp, int i)
> {
> @@ -174,6 +175,7 @@ static void exynos_spi_copy(unsigned int uboot_size, unsigned int uboot_addr)
> clrbits_le32(®s->ch_cfg, SPI_CH_RST);
> clrbits_le32(®s->ch_cfg, SPI_TX_CH_ON | SPI_RX_CH_ON);
> }
> +#endif
>
> /*
> * Copy U-boot from mmc to RAM:
> @@ -186,7 +188,9 @@ void copy_uboot_to_ram(void)
>
> u32 (*copy_bl2)(u32 offset, u32 nblock, u32 dst) = NULL;
> u32 offset = 0, size = 0;
> +#ifdef CONFIG_SPI_BOOTING
> struct spl_machine_param *param = spl_get_machine_params();
> +#endif
> #ifdef CONFIG_SUPPORT_EMMC_BOOT
> u32 (*copy_bl2_from_emmc)(u32 nblock, u32 dst);
> void (*end_bootop_from_emmc)(void);
>
applied to u-boot-samsung.
Thanks,
Minkyu Kang.
prev parent reply other threads:[~2013-12-06 10:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-06 10:25 [U-Boot] [PATCH] arm: exynos: adds ifdef for spi boot Minkyu Kang
2013-12-06 10:45 ` Minkyu Kang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A1AAE7.7060805@samsung.com \
--to=mk7.kang@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox