From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] t2080qds/ddr: update ddr parameters
Date: Fri, 6 Dec 2013 08:38:56 -0800 [thread overview]
Message-ID: <52A1FDA0.10708@freescale.com> (raw)
In-Reply-To: <1386320008-6169-1-git-send-email-Shengzhou.Liu@freescale.com>
On 12/06/2013 12:53 AM, Shengzhou Liu wrote:
> - optimize ddr parameters for whole frequency range from 1500MT/s to 2140MT/s.
> - remove unused patameters: 'cpo', 'wrdata delay', '2T', which is unrelated
> to DDR3/3L on t2080qds.
> - remove unused rdimm code(only udimm is supported on t2080qds).
>
> Signed-off-by: Shengzhou Liu <Shengzhou.Liu@freescale.com>
> ---
> Against master branch of git://git.denx.de/u-boot-mpc85xx.git
>
> board/freescale/t2080qds/ddr.c | 20 ++-----------
> board/freescale/t2080qds/ddr.h | 64 +++++++++---------------------------------
> 2 files changed, 17 insertions(+), 67 deletions(-)
>
> diff --git a/board/freescale/t2080qds/ddr.c b/board/freescale/t2080qds/ddr.c
> index 5db5d21..bc366ae 100644
> --- a/board/freescale/t2080qds/ddr.c
> +++ b/board/freescale/t2080qds/ddr.c
> @@ -24,24 +24,17 @@ void fsl_ddr_board_options(memctl_options_t *popts,
> const struct board_specific_parameters *pbsp, *pbsp_highest = NULL;
> ulong ddr_freq;
>
> - if (ctrl_num > 2) {
> + if (ctrl_num > 1) {
> printf("Not supported controller number %d\n", ctrl_num);
> return;
> }
> if (!pdimm->n_ranks)
> return;
>
> - /*
> - * we use identical timing for all slots. If needed, change the code
> - * to pbsp = rdimms[ctrl_num] or pbsp = udimms[ctrl_num];
> - */
> - if (popts->registered_dimm_en)
> - pbsp = rdimms[0];
> - else
> - pbsp = udimms[0];
> + pbsp = udimms[0];
>
This is not right. You should throw out an error if RDIMM is not
supported. But why isn't it supported? T2080 SoC can support RDIMM.
York
next prev parent reply other threads:[~2013-12-06 16:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-06 8:53 [U-Boot] [PATCH] t2080qds/ddr: update ddr parameters Shengzhou Liu
2013-12-06 16:38 ` York Sun [this message]
2013-12-09 6:12 ` Shengzhou.Liu at freescale.com
-- strict thread matches above, loose matches on Subject: below --
2014-01-06 9:26 Shengzhou Liu
2014-01-06 16:53 ` York Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A1FDA0.10708@freescale.com \
--to=yorksun@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox