public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] vexpress: fix timer address on non-A9 platforms
@ 2013-12-07 11:11 Marc Zyngier
  2013-12-07 21:03 ` Rob Herring
  0 siblings, 1 reply; 3+ messages in thread
From: Marc Zyngier @ 2013-12-07 11:11 UTC (permalink / raw)
  To: u-boot

Commit b3a7f22b3e09 (ARM: vexpress: convert to common timer code)
converted the VE timer code to the generic framework, but hardcoded
the timer address of the A9 testchip.

Change it for the appropriate macro that works on both core tiles.

Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
---
 include/configs/vexpress_common.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/configs/vexpress_common.h b/include/configs/vexpress_common.h
index 6da5e8f..7e78f8a 100644
--- a/include/configs/vexpress_common.h
+++ b/include/configs/vexpress_common.h
@@ -132,7 +132,7 @@
 #define VEXPRESS_FLASHPROG_FLVPPEN	(1 << 0)
 
 #define CONFIG_SYS_TIMER_RATE		1000000
-#define CONFIG_SYS_TIMER_COUNTER	(0x10011000 + 0x4)
+#define CONFIG_SYS_TIMER_COUNTER	(V2M_TIMER01 + 0x4)
 #define CONFIG_SYS_TIMER_COUNTS_DOWN
 
 /* SMSC9115 Ethernet from SMSC9118 family */
-- 
1.8.4.3

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] vexpress: fix timer address on non-A9 platforms
  2013-12-07 11:11 [U-Boot] [PATCH] vexpress: fix timer address on non-A9 platforms Marc Zyngier
@ 2013-12-07 21:03 ` Rob Herring
  2013-12-09  8:47   ` Marc Zyngier
  0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2013-12-07 21:03 UTC (permalink / raw)
  To: u-boot

On Sat, Dec 7, 2013 at 5:11 AM, Marc Zyngier <marc.zyngier@arm.com> wrote:
> Commit b3a7f22b3e09 (ARM: vexpress: convert to common timer code)
> converted the VE timer code to the generic framework, but hardcoded
> the timer address of the A9 testchip.
>
> Change it for the appropriate macro that works on both core tiles.
>
> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
> ---
>  include/configs/vexpress_common.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks for fixing my crap code. Andre and Ian already posted fixes for this.

http://patchwork.ozlabs.org/patch/294336/

Rob


>
> diff --git a/include/configs/vexpress_common.h b/include/configs/vexpress_common.h
> index 6da5e8f..7e78f8a 100644
> --- a/include/configs/vexpress_common.h
> +++ b/include/configs/vexpress_common.h
> @@ -132,7 +132,7 @@
>  #define VEXPRESS_FLASHPROG_FLVPPEN     (1 << 0)
>
>  #define CONFIG_SYS_TIMER_RATE          1000000
> -#define CONFIG_SYS_TIMER_COUNTER       (0x10011000 + 0x4)
> +#define CONFIG_SYS_TIMER_COUNTER       (V2M_TIMER01 + 0x4)
>  #define CONFIG_SYS_TIMER_COUNTS_DOWN
>
>  /* SMSC9115 Ethernet from SMSC9118 family */
> --
> 1.8.4.3
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] vexpress: fix timer address on non-A9 platforms
  2013-12-07 21:03 ` Rob Herring
@ 2013-12-09  8:47   ` Marc Zyngier
  0 siblings, 0 replies; 3+ messages in thread
From: Marc Zyngier @ 2013-12-09  8:47 UTC (permalink / raw)
  To: u-boot

On 07/12/13 21:03, Rob Herring wrote:
> On Sat, Dec 7, 2013 at 5:11 AM, Marc Zyngier <marc.zyngier@arm.com> wrote:
>> Commit b3a7f22b3e09 (ARM: vexpress: convert to common timer code)
>> converted the VE timer code to the generic framework, but hardcoded
>> the timer address of the A9 testchip.
>>
>> Change it for the appropriate macro that works on both core tiles.
>>
>> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
>> ---
>>  include/configs/vexpress_common.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Thanks for fixing my crap code. Andre and Ian already posted fixes for this.
> 
> http://patchwork.ozlabs.org/patch/294336/

Ah! My bad for not noticing it. Hopefully this will get merged soon
enough...

Cheers,

	M.
-- 
Jazz is not dead. It just smells funny...

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-12-09  8:47 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-07 11:11 [U-Boot] [PATCH] vexpress: fix timer address on non-A9 platforms Marc Zyngier
2013-12-07 21:03 ` Rob Herring
2013-12-09  8:47   ` Marc Zyngier

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox