From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?QW5kcmVhcyBCaWXDn21hbm4=?= Date: Mon, 09 Dec 2013 15:29:38 +0100 Subject: [U-Boot] [PATCH v5] at91: add support for CDU9G25 board In-Reply-To: <5236D103.5060103@aksignal.cz> References: <1379077245-2372-1-git-send-email-jiri.prchal@aksignal.cz> <52331CE2.3060804@gmail.com> <52332435.7020703@aksignal.cz> <5236C0E0.7000000@gmail.com> <5236D103.5060103@aksignal.cz> Message-ID: <52A5D3D2.1020108@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Ji?? Prchal, On 09/16/2013 11:36 AM, Ji?? Prchal wrote: > Dne 16.9.2013 10:27, Andreas Bie?mann napsal(a): >> On 09/13/2013 04:41 PM, Ji?? Prchal wrote: >>> Dne 13.9.2013 16:10, Andreas Bie?mann napsal(a): >>>> On 09/13/2013 03:00 PM, Jiri Prchal wrote: >> >> >> >>>>> diff --git a/arch/arm/include/asm/mach-types.h >>>>> b/arch/arm/include/asm/mach-types.h >>>>> index 440b041..9b274ba 100644 >>>>> --- a/arch/arm/include/asm/mach-types.h >>>>> +++ b/arch/arm/include/asm/mach-types.h >>>>> @@ -986,6 +986,7 @@ extern unsigned int __machine_arch_type; >>>>> #define MACH_TYPE_VIT_IBOX 3371 >>>>> #define MACH_TYPE_DM6441_ESP 3372 >>>>> #define MACH_TYPE_AT91SAM9X5EK 3373 >>>>> +#define MACH_TYPE_CDU9G25 3373 >>>> >>>> NAK, please obtain a mach type: >>>> http://www.arm.linux.org.uk/developer/machines/?action=new >>> >>> Should I register machine? I develop DT only: >>> "NOTE 1:If you are developing a DT-only platform, you do not need to >>> register a machine type for it. >>> Please do not register a machine type. Thanks." >>> Do I need this MACH_TYPE_* at all? >> >> I'm not really familiar with FDT only boards, but I think it is sane to >> just use a zero machid then. Could you please check this and if working >> just omit the machid setting? > > I'm not really familiar with FDT too, but I tested with 0 and it works. so eliminate the MACH id in your patch then. >>>>> +#define CONFIG_CMD_BOOTZ >>>>> +#define CONFIG_OF_LIBFDT >>>>> + >>>>> +/* general purpose I/O */ >>>>> +#define CONFIG_ATMEL_LEGACY /* required until (g)pio is >>>>> fixed */ >>>> >>>> I doubt you need this for gpio. Could you please check, if it is really >>>> required? > > Yes, it's required. > >>> Yes, I knew that, but I have looked many other board files and they use >>> both GPIO and PIO in one file. >>> If is necessary I'll re-base it to PIO. >> >> No, nand is not yet prepared for the generic gpio framework. I'll try to >> post patches next weeks (for 2014.01), but I'm quite busy right now. >> Since your board will also end up in 2014.01 this should go together. > > I'll wait for that. My changes are in u-boot-atmel/master now. If you send a rebased version of your patch I'll apply it for 2014.01 release. Best regards Andreas Bie?mann