From mboxrd@z Thu Jan 1 00:00:00 1970 From: York Sun Date: Mon, 9 Dec 2013 09:38:08 -0800 Subject: [U-Boot] [PATCH v2] t2080qds/ddr: update ddr parameters In-Reply-To: <1386574832-22926-1-git-send-email-Shengzhou.Liu@freescale.com> References: <1386574832-22926-1-git-send-email-Shengzhou.Liu@freescale.com> Message-ID: <52A60000.50906@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 12/08/2013 11:40 PM, Shengzhou Liu wrote: > - optimize ddr parameters for whole frequency range from 1500MT/s to 2140MT/s. > - remove unused patameters: 'cpo', 'wrdata delay', '2T', which is unrelated > to DDR3/3L on t2080qds. > - remove unused rdimm code(only udimm is supported on t2080qds board). We use upper case for RDIMM and UDIMM in commit message and comments. They mean Registered Dual In-line Memory Module, and Unbuffered Dual In-line Memory Module. > > Signed-off-by: Shengzhou Liu > --- > Against master branch of git://git.denx.de/u-boot-mpc85xx.git > v2: throw an error in case of rDIMM. > > board/freescale/t2080qds/ddr.c | 18 ++---------- > board/freescale/t2080qds/ddr.h | 64 +++++++++--------------------------------- > 2 files changed, 17 insertions(+), 65 deletions(-) > > diff --git a/board/freescale/t2080qds/ddr.c b/board/freescale/t2080qds/ddr.c > index 5db5d21..d877731 100644 > --- a/board/freescale/t2080qds/ddr.c > +++ b/board/freescale/t2080qds/ddr.c > @@ -24,24 +24,19 @@ void fsl_ddr_board_options(memctl_options_t *popts, > const struct board_specific_parameters *pbsp, *pbsp_highest = NULL; > ulong ddr_freq; > > - if (ctrl_num > 2) { > + if (ctrl_num > 1) { > printf("Not supported controller number %d\n", ctrl_num); > return; > } > if (!pdimm->n_ranks) > return; > > - /* > - * we use identical timing for all slots. If needed, change the code > - * to pbsp = rdimms[ctrl_num] or pbsp = udimms[ctrl_num]; > - */ > if (popts->registered_dimm_en) > - pbsp = rdimms[0]; > + puts("ERROR: rDIMM is not supported on t2080qds board\n"); Don't use rDIMM, use RDIMM instead. I suggest you to consult board designer. I don't see why RDIMM should be dropped for this board. York