From: Bo Shen <voice.shen@atmel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/4] usb: dfu: f_dfu: Provide infrastructure to adjust DFU's Poll Timeout value
Date: Tue, 10 Dec 2013 16:37:16 +0800 [thread overview]
Message-ID: <52A6D2BC.9040709@atmel.com> (raw)
In-Reply-To: <20131210092701.354373b8@amdc2363>
Hi Lukasz,
On 12/10/2013 04:27 PM, Lukasz Majewski wrote:
> Hi Bo,
>
>> Hi Lukasz,
>>
>> On 12/09/2013 11:20 PM, Lukasz Majewski wrote:
>>> diff --git a/drivers/usb/gadget/f_dfu.h b/drivers/usb/gadget/f_dfu.h
>>> index cc2c455..0c29954 100644
>>> --- a/drivers/usb/gadget/f_dfu.h
>>> +++ b/drivers/usb/gadget/f_dfu.h
>>> @@ -82,4 +82,6 @@ struct dfu_function_descriptor {
>>> __le16 wTransferSize;
>>> __le16 bcdDFUVersion;
>>> } __packed;
>>> +
>>> +#define DFU_POLL_TIMEOUT_MASK (0xFFFFFFUL)
>>
>> Why this value? How about (~0UL)?
>
> According to DFU 1.1 standard, the bwPolTimeout field of DFU_GETSTATUS
> request has 3 bytes in size.
Thanks for clarify this.
Tested OK on sama5d3xek board.
Tested-by: Bo Shen <voice.shen@atmel.com>
>>
>>> #endif /* __F_DFU_H_ */
>>
>> Best Regards,
>> Bo Shen
>
Best Regards,
Bo Shen
next prev parent reply other threads:[~2013-12-10 8:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-09 15:20 [U-Boot] [PATCH 0/4] dfu: Provide proper Poll Timeout values Lukasz Majewski
2013-12-09 15:20 ` [U-Boot] [PATCH 1/4] dfu: Export allocated dfu buffer size Lukasz Majewski
2013-12-10 10:49 ` Heiko Schocher
2013-12-09 15:20 ` [U-Boot] [PATCH 2/4] usb: dfu: f_dfu: Provide infrastructure to adjust DFU's Poll Timeout value Lukasz Majewski
2013-12-10 6:34 ` Bo Shen
2013-12-10 8:27 ` Lukasz Majewski
2013-12-10 8:37 ` Bo Shen [this message]
2013-12-10 10:49 ` Heiko Schocher
2013-12-09 15:20 ` [U-Boot] [PATCH 3/4] usb: f_dfu: cosmetic: Code cleanup Lukasz Majewski
2013-12-10 10:49 ` Heiko Schocher
2013-12-09 15:20 ` [U-Boot] [PATCH 4/4] ARM: trats: dfu: Enable default Poll Timeout for Trats board Lukasz Majewski
2013-12-10 10:50 ` Heiko Schocher
2013-12-10 9:54 ` [U-Boot] [PATCH 0/4] dfu: Provide proper Poll Timeout values Lukasz Majewski
2013-12-10 10:24 ` Heiko Schocher
2013-12-10 14:10 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A6D2BC.9040709@atmel.com \
--to=voice.shen@atmel.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox