From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bo Shen Date: Tue, 10 Dec 2013 16:37:16 +0800 Subject: [U-Boot] [PATCH 2/4] usb: dfu: f_dfu: Provide infrastructure to adjust DFU's Poll Timeout value In-Reply-To: <20131210092701.354373b8@amdc2363> References: <1386602416-12863-1-git-send-email-l.majewski@samsung.com> <1386602416-12863-3-git-send-email-l.majewski@samsung.com> <52A6B5D8.9000607@atmel.com> <20131210092701.354373b8@amdc2363> Message-ID: <52A6D2BC.9040709@atmel.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Lukasz, On 12/10/2013 04:27 PM, Lukasz Majewski wrote: > Hi Bo, > >> Hi Lukasz, >> >> On 12/09/2013 11:20 PM, Lukasz Majewski wrote: >>> diff --git a/drivers/usb/gadget/f_dfu.h b/drivers/usb/gadget/f_dfu.h >>> index cc2c455..0c29954 100644 >>> --- a/drivers/usb/gadget/f_dfu.h >>> +++ b/drivers/usb/gadget/f_dfu.h >>> @@ -82,4 +82,6 @@ struct dfu_function_descriptor { >>> __le16 wTransferSize; >>> __le16 bcdDFUVersion; >>> } __packed; >>> + >>> +#define DFU_POLL_TIMEOUT_MASK (0xFFFFFFUL) >> >> Why this value? How about (~0UL)? > > According to DFU 1.1 standard, the bwPolTimeout field of DFU_GETSTATUS > request has 3 bytes in size. Thanks for clarify this. Tested OK on sama5d3xek board. Tested-by: Bo Shen >> >>> #endif /* __F_DFU_H_ */ >> >> Best Regards, >> Bo Shen > Best Regards, Bo Shen