From mboxrd@z Thu Jan  1 00:00:00 1970
From: Przemyslaw Marczak <p.marczak@samsung.com>
Date: Wed, 11 Dec 2013 11:00:23 +0100
Subject: [U-Boot] [PATCH 03/10] samsung: common: Add misc file and
 common function misc_init_r().
In-Reply-To: <52A81F5E.8050708@samsung.com>
References: <1386093806-2948-1-git-send-email-p.marczak@samsung.com>
	<1386093806-2948-4-git-send-email-p.marczak@samsung.com>
	<52A81F5E.8050708@samsung.com>
Message-ID: <52A837B7.2030204@samsung.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hello Minkyu,

On 12/11/2013 09:16 AM, Minkyu Kang wrote:
> On 04/12/13 03:03, Przemyslaw Marczak wrote:
>> Config options:
>> - CONFIG_SAMSUNG - misc.c
>> - CONFIG_MISC_INIT_R - function misc_init_r();
>>
>> New file:
>> - board/samsung/common/misc.c
>>
>> Signed-off-by: Przemyslaw Marczak <p.marczak@samsung.com>
>> ---
>>   board/samsung/common/Makefile |    1 +
>>   board/samsung/common/misc.c   |   16 ++++++++++++++++
>>   2 files changed, 17 insertions(+)
>>   create mode 100644 board/samsung/common/misc.c
>>
>> diff --git a/board/samsung/common/Makefile b/board/samsung/common/Makefile
>> index 501d974..d1eb63f 100644
>> --- a/board/samsung/common/Makefile
>> +++ b/board/samsung/common/Makefile
>> @@ -8,3 +8,4 @@
>>   obj-$(CONFIG_SOFT_I2C_MULTI_BUS) += multi_i2c.o
>>   obj-$(CONFIG_THOR_FUNCTION) += thor.o
>>   obj-$(CONFIG_CMD_USB_MASS_STORAGE) += ums.o
>> +obj-$(CONFIG_SAMSUNG) += misc.o
>
> Why CONFIG_SAMSUNG?
> We know this Makefile is for samsung boards.
>
Right, I will change it to CONFIG_MISC_INIT_R, and this ifdef will be 
removed from misc.c.

>> diff --git a/board/samsung/common/misc.c b/board/samsung/common/misc.c
>> new file mode 100644
>> index 0000000..465895b
>> --- /dev/null
>> +++ b/board/samsung/common/misc.c
>> @@ -0,0 +1,16 @@
>> +/*
>> + * Copyright (C) 2013 Samsung Electronics
>> + * Przemyslaw Marczak <p.marczak@samsung.com>
>> + *
>> + * SPDX-License-Identifier:	GPL-2.0+
>> + */
>> +
>> +#include <common.h>
>> +
>> +#ifdef CONFIG_MISC_INIT_R
>> +/* Common for Samsung boards */
>> +int misc_init_r(void)
>> +{
>> +	return 0;
>> +}
>> +#endif /* CONFIG_MISC_INIT_R */
>>
>
> Thanks,
> Minkyu Kang.
>
>

Regards
-- 
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com