[U-Boot] [PATCH v5] arm: omap3: Add SPL support to cm_t35

Igor Grinberg
2013-12-12T08:27:33Z

On 12/11/13 16:55, Stefan Roese wrote:
> Hi Igor!
>
> On 11.12.2013 15:35, Igor Grinberg wrote:
>> Finally, I've found some time to look at the patch...
>> Generally, it is fine...
>> I say generally, because we have found several bugs, but they
>> are not related to your patch... but to Pekon's work on the
>> omap nand driver. Nikita is on them ;-)
>
> Good. :)
>
>> One minor comment below...
>
> <snip>
>
>>> +/* Defines for SPL */
>>> +#define CONFIG_SPL
>>> +#define CONFIG_SPL_FRAMEWORK
>>> +#define CONFIG_SPL_NAND_SIMPLE
>>> +
>>> +#define CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR 0x300 /* address 0x60000 */
>>> +#define CONFIG_SYS_U_BOOT_MAX_SIZE_SECTORS 0x200 /* 256 KB */
>>
>> Our U-Boot binary sizes are beyond 300KiB...
>> This config is not used anywhere besides config files and README...
>> That's why it probably works for you...
>> I think we should either remove it from the README and configs, or
>> set it to 0x300 or even 0x400 instead (in case we still want to use it,
>> although I don't know why, as we have the size from the image header).
>
> Good catch. If it is not used/referenced at all, then let's remove it
> completely. It makes no sense to drag such an unused define along. Could
> lead only to confusion.
>
> But we can and should remove this in a separate patch.

Fare enough!

Tom, can you please apply this one?

Thanks!

--
Regards,
Igor.