From: Nikita Kiryanov <nikita@compulab.co.il>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: omap: nand: setup sw ecc size using default value
Date: Thu, 12 Dec 2013 15:16:41 +0200 [thread overview]
Message-ID: <52A9B739.1000104@compulab.co.il> (raw)
In-Reply-To: <20980858CB6D3A4BAE95CA194937D5E73EA549BC@DBDE04.ent.ti.com>
On 12/12/2013 02:10 PM, Gupta, Pekon wrote:
> Hi Nikita,
>
> Just minor feedback ..
>
>> From: Nikita Kiryanov [mailto:nikita at compulab.co.il]
>> Subject: [PATCH] arm: omap: nand: setup sw ecc size using default value
>>
> Just include ""mtd: nand: omap: fix HAM1_SW" ... as prefix to your patch title.
> Example: "mtd: nand: omap: fix HAM1_SW using default setup to assign ecc.size"
> This is helpful while cherry picking patches, As patch title gives some knowledge
> of what patch does, and what all it touches.
OK I'll incorporate this into the title
>
> [...]
>> bch_priv.type = 0;
>> nand->ecc.mode = NAND_ECC_SOFT;
>> nand->ecc.layout = NULL;
>> - nand->ecc.size = pagesize;
>> + nand->ecc.size = 0;
> Also, nand->ecc.size = NULL; is equally readable..
I know the result is the same, but conceptually this is not correct.
ecc.size is an int, not a pointer.
> (though no issues here)..
>
>
> with regards, pekon
>
--
Regards,
Nikita.
next prev parent reply other threads:[~2013-12-12 13:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-12 12:01 [U-Boot] [PATCH] arm: omap: nand: setup sw ecc size using default value Nikita Kiryanov
2013-12-12 12:10 ` Gupta, Pekon
2013-12-12 13:16 ` Nikita Kiryanov [this message]
2013-12-12 13:19 ` [U-Boot] [PATCH V2] mtd: nand: omap: fix HAM1_SW ecc using default value for ecc.size Nikita Kiryanov
2013-12-12 13:23 ` Gupta, Pekon
2013-12-17 23:42 ` [U-Boot] [U-Boot, " Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A9B739.1000104@compulab.co.il \
--to=nikita@compulab.co.il \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox