From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nikita Kiryanov <nikita@compulab.co.il>
Date: Thu, 12 Dec 2013 15:16:41 +0200
Subject: [U-Boot] [PATCH] arm: omap: nand: setup sw ecc size using
	default value
In-Reply-To: <20980858CB6D3A4BAE95CA194937D5E73EA549BC@DBDE04.ent.ti.com>
References: <1386849661-7119-1-git-send-email-nikita@compulab.co.il>
	<20980858CB6D3A4BAE95CA194937D5E73EA549BC@DBDE04.ent.ti.com>
Message-ID: <52A9B739.1000104@compulab.co.il>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 12/12/2013 02:10 PM, Gupta, Pekon wrote:
> Hi Nikita,
>
> Just minor feedback ..
>
>> From: Nikita Kiryanov [mailto:nikita at compulab.co.il]
>> Subject: [PATCH] arm: omap: nand: setup sw ecc size using default value
>>
> Just include ""mtd: nand: omap: fix HAM1_SW" ... as prefix to your patch title.
> Example: "mtd: nand: omap: fix HAM1_SW  using default setup to assign ecc.size"
> This is helpful while cherry picking patches, As patch title gives some knowledge
> of what patch does, and what all it touches.

OK I'll incorporate this into the title

>
> [...]
>> 		bch_priv.type		= 0;
>> 		nand->ecc.mode		= NAND_ECC_SOFT;
>> 		nand->ecc.layout	= NULL;
>> -		nand->ecc.size		= pagesize;
>> +		nand->ecc.size		= 0;
> Also, 		nand->ecc.size		= NULL;  is equally readable..

I know the result is the same, but conceptually this is not correct.
ecc.size is an int, not a pointer.

> (though no issues here)..
>
>
> with regards, pekon
>


-- 
Regards,
Nikita.