From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM: mxs: tools: Fix errno handling in strtoul() invocation
Date: Tue, 17 Dec 2013 18:46:13 +0100 [thread overview]
Message-ID: <52B08DE5.1030105@denx.de> (raw)
In-Reply-To: <1386163660-21428-1-git-send-email-marex@denx.de>
On 04/12/2013 14:27, Marek Vasut wrote:
> According to NOTE in strtoul(3), the errno must be zeroed before strtoul()
> is called. Zero the errno. The NOTE reads as such:
>
> Since strtoul() can legitimately return 0 or ULONG_MAX (ULLONG_MAX for
> strtoull()) on both success and failure, the calling program should set
> errno to 0 before the call, and then determine if an error occurred
> by checking whether errno has a nonzero value after the call.
>
> This issue was detected on Fedora 19 with glibc 2.17 .
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Tom Rini <trini@ti.com>
> ---
Applied to u-boot-imx, thanks.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
prev parent reply other threads:[~2013-12-17 17:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-04 13:27 [U-Boot] [PATCH] ARM: mxs: tools: Fix errno handling in strtoul() invocation Marek Vasut
2013-12-17 17:46 ` Stefano Babic [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B08DE5.1030105@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox