[U-Boot] [PATCH] ARM: mxs: tools: Fix errno handling in strtoul() invocation

[U-Boot] [PATCH] ARM: mxs: tools: Fix errno handling in strtoul() invocation

[Marek Vasut]

According to NOTE in strtoul(3), the errno must be zeroed before strtoul()
is called. Zero the errno. The NOTE reads as such:

  Since strtoul() can legitimately return 0 or ULONG_MAX (ULLONG_MAX for
  strtoull()) on both success and failure, the calling program should set
  errno  to  0  before the call, and then determine if an error occurred
  by checking whether errno has a nonzero value after the call.

This issue was detected on Fedora 19 with glibc 2.17 .

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Stefano Babic <sbabic@denx.de>
Cc: Tom Rini <trini@ti.com>
---
 tools/mxsimage.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/mxsimage.c b/tools/mxsimage.c
index 5db19b2..7bd9dee 100644
--- a/tools/mxsimage.c
+++ b/tools/mxsimage.c
@@ -502,6 +502,7 @@ static int sb_token_to_long(char *tok, uint32_t *rid)
 
 	tok += 2;
 
+	errno = 0;
 	id = strtoul(tok, &endptr, 16);
 	if ((errno == ERANGE && id == ULONG_MAX) || (errno != 0 && id == 0)) {
 		fprintf(stderr, "ERR: Value can't be decoded!\n");
-- 
1.8.4.2

[U-Boot] [PATCH] ARM: mxs: tools: Fix errno handling in strtoul() invocation

[Stefano Babic]

On 04/12/2013 14:27, Marek Vasut wrote:
> According to NOTE in strtoul(3), the errno must be zeroed before strtoul()
> is called. Zero the errno. The NOTE reads as such:
> 
>   Since strtoul() can legitimately return 0 or ULONG_MAX (ULLONG_MAX for
>   strtoull()) on both success and failure, the calling program should set
>   errno  to  0  before the call, and then determine if an error occurred
>   by checking whether errno has a nonzero value after the call.
> 
> This issue was detected on Fedora 19 with glibc 2.17 .
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Tom Rini <trini@ti.com>
> ---


Applied to u-boot-imx, thanks.

Best regards,
Stefano Babic



-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================