From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefano Babic Date: Tue, 17 Dec 2013 18:46:13 +0100 Subject: [U-Boot] [PATCH] ARM: mxs: tools: Fix errno handling in strtoul() invocation In-Reply-To: <1386163660-21428-1-git-send-email-marex@denx.de> References: <1386163660-21428-1-git-send-email-marex@denx.de> Message-ID: <52B08DE5.1030105@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 04/12/2013 14:27, Marek Vasut wrote: > According to NOTE in strtoul(3), the errno must be zeroed before strtoul() > is called. Zero the errno. The NOTE reads as such: > > Since strtoul() can legitimately return 0 or ULONG_MAX (ULLONG_MAX for > strtoull()) on both success and failure, the calling program should set > errno to 0 before the call, and then determine if an error occurred > by checking whether errno has a nonzero value after the call. > > This issue was detected on Fedora 19 with glibc 2.17 . > > Signed-off-by: Marek Vasut > Cc: Stefano Babic > Cc: Tom Rini > --- Applied to u-boot-imx, thanks. Best regards, Stefano Babic -- ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================