[U-Boot] [PATCH v2 23/35] nand: Add zynq nand controller driver support

[Michal Simek <monstr@monstr.eu>]

On 12/18/2013 08:07 PM, Jagan Teki wrote:
> On Wed, Dec 18, 2013 at 9:07 PM, Marek Vasut <marex@denx.de> wrote:
>> On Wednesday, December 18, 2013 at 04:30:08 PM, Jagannadha Sutradharudu Teki
>> wrote:
>>> Added support for Zynq Nand controller driver.
>>>
>>> Signed-off-by: Jagannadha Sutradharudu Teki <jaganna@xilinx.com>
>>> CC: Marek Vasut <marex@denx.de>
>>> Cc: Scott Wood <scottwood@freescale.com>
>>> ---
>>> V2: Fixed issues pointed by Scott
>>>
>>>  arch/arm/include/asm/arch-zynq/hardware.h |    2 +
>>>  drivers/mtd/nand/Makefile                 |    1 +
>>>  drivers/mtd/nand/zynq_nand.c              | 1198
>>> +++++++++++++++++++++++++++++ 3 files changed, 1201 insertions(+)
>>>  create mode 100644 drivers/mtd/nand/zynq_nand.c
>>
>> [...]
>>
>>> +#define zynq_nand_smc_base   ((struct zynq_nand_smc_regs __iomem *)\
>>> +                             ZYNQ_SMC_BASEADDR)
>>
>> Why don't you make this a static const * variable ?
> 
> For accessing base from all func - may be I will through structure
> pointer and access.

Jagan as I told you you shouldn't add this patch and also that qspi one
to this series. qspi and nand should go as separate patches out of this series.
Then there is exact responsibility for it.

Thanks,
Michal


-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 263 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20131219/803b81d2/attachment.pgp>