public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Lubomir Popov <lpopov@mm-sol.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC PATCH 2/2] ARM: omap5_uevm: Example usage of alternative HSIC USB device reset
Date: Thu, 19 Dec 2013 16:54:36 +0200	[thread overview]
Message-ID: <52B308AC.3040604@mm-sol.com> (raw)

This patch demonstrates the usage of the alternative method for HSIC
devices reset (via the ehci-hcd and omap-ehci drivers, where this
method is implemented through a separate patch; must be applied prior
to this one). Board functionality is not altered; a minor improvement
is the removal of the second call to omap_ehci_hcd_init() after reset
which is not needed anymore.

On some other OMAP4/5 boards however this is the only method that
works.

Signed-off-by: Lubomir Popov <l-popov@ti.com>
---
 board/ti/omap5_uevm/evm.c    |    2 ++
 include/configs/omap5_uevm.h |   13 ++++++++++---
 2 files changed, 12 insertions(+), 3 deletions(-)

diff --git a/board/ti/omap5_uevm/evm.c b/board/ti/omap5_uevm/evm.c
index af854da..cae9fd8 100644
--- a/board/ti/omap5_uevm/evm.c
+++ b/board/ti/omap5_uevm/evm.c
@@ -210,6 +210,7 @@ int ehci_hcd_stop(void)
 	return ret;
 }

+#if !defined(CONFIG_OMAP_HSIC_PORT3_RESET_GPIO)
 void usb_hub_reset_devices(int port)
 {
 	/* The LAN9730 needs to be reset after the port power has been set. */
@@ -220,6 +221,7 @@ void usb_hub_reset_devices(int port)
 	}
 }
 #endif
+#endif

 #ifdef CONFIG_USB_XHCI_OMAP
 /**
diff --git a/include/configs/omap5_uevm.h b/include/configs/omap5_uevm.h
index 2f128b8..96b5f23 100644
--- a/include/configs/omap5_uevm.h
+++ b/include/configs/omap5_uevm.h
@@ -50,10 +50,17 @@
 #define CONFIG_USB_EHCI_OMAP
 #define CONFIG_USB_STORAGE
 #define CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS 3
-#define CONFIG_EHCI_HCD_INIT_AFTER_RESET
+/*#define CONFIG_EHCI_HCD_INIT_AFTER_RESET*/

-#define CONFIG_OMAP_EHCI_PHY2_RESET_GPIO 80
-#define CONFIG_OMAP_EHCI_PHY3_RESET_GPIO 79
+/* No ULPI PHYs on this board */
+/*#define CONFIG_OMAP_EHCI_PHY2_RESET_GPIO 80*/
+/*#define CONFIG_OMAP_EHCI_PHY3_RESET_GPIO 79*/
+/*
+ * Due to HSIC connect ussues with some devices, a reset is required
+ * upon applying port power. A GPIO is needed per HSIC device:
+ */
+#define CONFIG_OMAP_HSIC_PORT2_RESET_GPIO	80	/* Hub */
+#define CONFIG_OMAP_HSIC_PORT3_RESET_GPIO	79	/* Ethernet Ctrlr */

 /* Enabled commands */
 #define CONFIG_CMD_DHCP		/* DHCP Support			*/
-- 
1.7.9.5

                 reply	other threads:[~2013-12-19 14:54 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52B308AC.3040604@mm-sol.com \
    --to=lpopov@mm-sol.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox