public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jaehoon Chung <jh80.chung@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] board:trats2: fix default partitions and mmc env
Date: Thu, 26 Dec 2013 17:02:41 +0900	[thread overview]
Message-ID: <52BBE2A1.8090004@samsung.com> (raw)
In-Reply-To: <1387462194-5887-1-git-send-email-p.wilczek@samsung.com>

Hi, Piotr.

On 12/19/2013 11:09 PM, Piotr Wilczek wrote:
> This patch add uuid disk to defualt partions necessary to
> restore gpt partitions and fixes mmcdev environmental variable.
> 
> Signed-off-by: Piotr Wilczek <p.wilczek@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
>  include/configs/trats2.h |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/include/configs/trats2.h b/include/configs/trats2.h
> index 5d86a3d..4c0068b 100644
> --- a/include/configs/trats2.h
> +++ b/include/configs/trats2.h
> @@ -160,6 +160,7 @@
>  #define PARTS_UMS		"ums"
>  
>  #define PARTS_DEFAULT \
> +	"uuid_disk=${uuid_gpt_disk};" \
>  	"name="PARTS_CSA",start=5MiB,size=8MiB,uuid=${uuid_gpt_"PARTS_CSA"};" \
>  	"name="PARTS_BOOT",size=64MiB,uuid=${uuid_gpt_"PARTS_BOOT"};" \
>  	"name="PARTS_MODEM",size=100MiB,uuid=${uuid_gpt_"PARTS_MODEM"};" \
> @@ -201,7 +202,7 @@
>  		"${kernelname}\0" \
>  	"loaddtb=ext4load mmc ${mmcdev}:${mmcbootpart} ${fdtaddr} " \
>  		"${fdtfile}\0" \
> -	"mmcdev=CONFIG_MMC_DEFAULT_DEV\0" \
> +	"mmcdev=0\0" \
What difference is CONFIG_MMC_DEFAULT_DEV and 0?
CONFIG_MMC_DEFAULT_DEV 0 is defined. Maybe, mmcdev is set to 0, isn't?
(It recognized that CONFIG_MMC_DEFAULT_DEV isn't defined.)

Best Regards,
Jaehoon Chung
>  	"mmcbootpart=2\0" \
>  	"mmcrootpart=5\0" \
>  	"opts=always_resume=1\0" \
> 

  reply	other threads:[~2013-12-26  8:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-19 14:09 [U-Boot] [PATCH] board:trats2: fix default partitions and mmc env Piotr Wilczek
2013-12-26  8:02 ` Jaehoon Chung [this message]
2013-12-30  8:54   ` Piotr Wilczek
2013-12-30  8:40 ` [U-Boot] [PATCH V2] " Piotr Wilczek
2013-12-31  7:44   ` Minkyu Kang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52BBE2A1.8090004@samsung.com \
    --to=jh80.chung@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox