u-boot.lists.denx.de archive mirror
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] ARM: twister: add missing gpio clock init
@ 2013-12-21 17:06 Jeroen Hofstee
  2013-12-27 10:53 ` Stefano Babic
  2014-01-08 13:34 ` [U-Boot] " Tom Rini
  0 siblings, 2 replies; 3+ messages in thread
From: Jeroen Hofstee @ 2013-12-21 17:06 UTC (permalink / raw)
  To: u-boot

Commit f33b9bd3984fb11e1d8566a866adc5957b1e1c9d breaks boards
which do not explicitly enable the gpio clocks. This causes
the twister spl to hang, since it uses the no longer enabled
gpio 55. Add CONFIG_OMAP3_GPIO_2 to unbrick the board.

Cc: Stefano Babic <sbabic@denx.de>
Cc: Tapani Utriainen <tapani@technexion.com>
Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>
---
 include/configs/twister.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/include/configs/twister.h b/include/configs/twister.h
index b6ca59c..f24dc13 100644
--- a/include/configs/twister.h
+++ b/include/configs/twister.h
@@ -50,4 +50,7 @@
 #define CONFIG_SYS_SPL_ARGS_ADDR	(PHYS_SDRAM_1 + 0x100)
 #define CONFIG_SPL_BOARD_INIT
 
+/* gpio 55 is used as SPL_OS_BOOT_KEY */
+#define CONFIG_OMAP3_GPIO_2
+
 #endif /* __CONFIG_H */
-- 
1.8.3.2

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] ARM: twister: add missing gpio clock init
  2013-12-21 17:06 [U-Boot] [PATCH] ARM: twister: add missing gpio clock init Jeroen Hofstee
@ 2013-12-27 10:53 ` Stefano Babic
  2014-01-08 13:34 ` [U-Boot] " Tom Rini
  1 sibling, 0 replies; 3+ messages in thread
From: Stefano Babic @ 2013-12-27 10:53 UTC (permalink / raw)
  To: u-boot

On 21/12/2013 18:06, Jeroen Hofstee wrote:
> Commit f33b9bd3984fb11e1d8566a866adc5957b1e1c9d breaks boards
> which do not explicitly enable the gpio clocks. This causes
> the twister spl to hang, since it uses the no longer enabled
> gpio 55. Add CONFIG_OMAP3_GPIO_2 to unbrick the board.
> 
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Tapani Utriainen <tapani@technexion.com>
> Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>
> ---
>  include/configs/twister.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/include/configs/twister.h b/include/configs/twister.h
> index b6ca59c..f24dc13 100644
> --- a/include/configs/twister.h
> +++ b/include/configs/twister.h
> @@ -50,4 +50,7 @@
>  #define CONFIG_SYS_SPL_ARGS_ADDR	(PHYS_SDRAM_1 + 0x100)
>  #define CONFIG_SPL_BOARD_INIT
>  
> +/* gpio 55 is used as SPL_OS_BOOT_KEY */
> +#define CONFIG_OMAP3_GPIO_2
> +
>  #endif /* __CONFIG_H */
> 


Acked-by: Stefano Babic <sbabic@denx.de>

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] ARM: twister: add missing gpio clock init
  2013-12-21 17:06 [U-Boot] [PATCH] ARM: twister: add missing gpio clock init Jeroen Hofstee
  2013-12-27 10:53 ` Stefano Babic
@ 2014-01-08 13:34 ` Tom Rini
  1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2014-01-08 13:34 UTC (permalink / raw)
  To: u-boot

On Sat, Dec 21, 2013 at 06:06:33PM +0100, Jeroen Hofstee wrote:

> Commit f33b9bd3984fb11e1d8566a866adc5957b1e1c9d breaks boards
> which do not explicitly enable the gpio clocks. This causes
> the twister spl to hang, since it uses the no longer enabled
> gpio 55. Add CONFIG_OMAP3_GPIO_2 to unbrick the board.
> 
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Tapani Utriainen <tapani@technexion.com>
> Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>
> Acked-by: Stefano Babic <sbabic@denx.de>

Applied to u-boot-ti/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20140108/6b1997c4/attachment.pgp>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-01-08 13:34 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-21 17:06 [U-Boot] [PATCH] ARM: twister: add missing gpio clock init Jeroen Hofstee
2013-12-27 10:53 ` Stefano Babic
2014-01-08 13:34 ` [U-Boot] " Tom Rini

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).