From mboxrd@z Thu Jan  1 00:00:00 1970
From: Minkyu Kang <mk7.kang@samsung.com>
Date: Thu, 02 Jan 2014 15:34:56 +0900
Subject: [U-Boot] [PATCH v2 12/13] trats2: add LCD download menu support
In-Reply-To: <60833c312cbc70300a41ce8e5e7fadb405c09469.1387390491.git.p.marczak@samsung.com>
References: <cover.1387390491.git.p.marczak@samsung.com>
	<60833c312cbc70300a41ce8e5e7fadb405c09469.1387390491.git.p.marczak@samsung.com>
Message-ID: <52C50890.1080601@samsung.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 19/12/13 03:31, Przemyslaw Marczak wrote:
> Signed-off-by: Przemyslaw Marczak <p.marczak@samsung.com>
> 
> ---
> changes v2:
> - add definitions for check keys
> - cleanup config definitions
> ---
>  include/configs/trats2.h |   27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
> 
> diff --git a/include/configs/trats2.h b/include/configs/trats2.h
> index 80d3ed0..b0dcfa4 100644
> --- a/include/configs/trats2.h
> +++ b/include/configs/trats2.h
> @@ -19,6 +19,8 @@
>  #define CONFIG_S5P		/* which is in a S5P Family */
>  #define CONFIG_EXYNOS4		/* which is in a EXYNOS4XXX */
>  #define CONFIG_TIZEN		/* TIZEN lib */
> +#define CONFIG_TRATS2
> +#define CONFIG_BOARD_NAME	"TRATS2"
>  
>  #include <asm/arch/cpu.h>		/* get chip and board defs */
>  
> @@ -319,6 +321,31 @@
>  /* Common misc for Samsung */
>  #define CONFIG_MISC_INIT_R
>  
> +/* Download menu - Samsung common */
> +#define CONFIG_LCD_MENU
> +#define CONFIG_LCD_MENU_BOARD
> +
> +/* Download menu - definitions for check keys */
> +#ifndef __ASSEMBLY__
> +#ifdef __COMMON_H_

why this ifdef(__COMMON_H_) is needed?

> +#include <power/pmic.h>
> +#include <power/max77686_pmic.h>
> +
> +#define KEY_PWR_PMIC_NAME		"MAX77686_PMIC"
> +#define KEY_PWR_STATUS_REG		MAX77686_REG_PMIC_STATUS1
> +#define KEY_PWR_STATUS_MASK		(1 << 0)
> +#define KEY_PWR_INTERRUPT_REG		MAX77686_REG_PMIC_INT1
> +#define KEY_PWR_INTERRUPT_MASK		(1 << 1)
> +
> +#define KEY_VOL_UP_GPIO			exynos4x12_gpio_get(2, x2, 2)
> +#define KEY_VOL_DOWN_GPIO		exynos4x12_gpio_get(2, x3, 3)
> +#endif /* __COMMON_H_ */
> +#endif /* __ASSEMBLY__ */
> +
> +/* LCD console */
> +#define LCD_BPP                 LCD_COLOR16
> +#define CONFIG_SYS_WHITE_ON_BLACK
> +
>  /* LCD */
>  #define CONFIG_EXYNOS_FB
>  #define CONFIG_LCD
> 

Thanks,
Minkyu Kang.