public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] powerpc/83xx: fix compilation error for MPC8315ERDB
@ 2013-12-20  3:54 Nikhil Badola
  2014-01-02 21:44 ` York Sun
  2014-01-03 19:27 ` Scott Wood
  0 siblings, 2 replies; 3+ messages in thread
From: Nikhil Badola @ 2013-12-20  3:54 UTC (permalink / raw)
  To: u-boot

From: Ramneek Mehresh <ramneek.mehresh@freescale.com>

Defines get_svr() for 83xx devices

Signed-off-by: Ramneek Mehresh <ramneek.mehresh@freescale.com>
---
 arch/powerpc/cpu/mpc83xx/start.S | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/powerpc/cpu/mpc83xx/start.S b/arch/powerpc/cpu/mpc83xx/start.S
index b4fafe6..7f74a50 100644
--- a/arch/powerpc/cpu/mpc83xx/start.S
+++ b/arch/powerpc/cpu/mpc83xx/start.S
@@ -120,6 +120,11 @@ disable_addr_trans:
 	mtspr	SRR1, r3
 	rfi
 
+	.globl get_svr
+get_svr:
+	mfspr	r3, SVR
+	blr
+
 	.globl get_pvr
 get_pvr:
 	mfspr	r3, PVR
-- 
1.7.11.7

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] powerpc/83xx: fix compilation error for MPC8315ERDB
  2013-12-20  3:54 [U-Boot] [PATCH] powerpc/83xx: fix compilation error for MPC8315ERDB Nikhil Badola
@ 2014-01-02 21:44 ` York Sun
  2014-01-03 19:27 ` Scott Wood
  1 sibling, 0 replies; 3+ messages in thread
From: York Sun @ 2014-01-02 21:44 UTC (permalink / raw)
  To: u-boot

On 12/19/2013 07:54 PM, Nikhil Badola wrote:
> From: Ramneek Mehresh <ramneek.mehresh@freescale.com>
> 
> Defines get_svr() for 83xx devices
> 
> Signed-off-by: Ramneek Mehresh <ramneek.mehresh@freescale.com>
> ---
>  arch/powerpc/cpu/mpc83xx/start.S | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/powerpc/cpu/mpc83xx/start.S b/arch/powerpc/cpu/mpc83xx/start.S
> index b4fafe6..7f74a50 100644
> --- a/arch/powerpc/cpu/mpc83xx/start.S
> +++ b/arch/powerpc/cpu/mpc83xx/start.S
> @@ -120,6 +120,11 @@ disable_addr_trans:
>  	mtspr	SRR1, r3
>  	rfi
>  
> +	.globl get_svr
> +get_svr:
> +	mfspr	r3, SVR
> +	blr
> +
>  	.globl get_pvr
>  get_pvr:
>  	mfspr	r3, PVR
> 

Please share how to reproduce the compilation error. I don't see it.

York

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] powerpc/83xx: fix compilation error for MPC8315ERDB
  2013-12-20  3:54 [U-Boot] [PATCH] powerpc/83xx: fix compilation error for MPC8315ERDB Nikhil Badola
  2014-01-02 21:44 ` York Sun
@ 2014-01-03 19:27 ` Scott Wood
  1 sibling, 0 replies; 3+ messages in thread
From: Scott Wood @ 2014-01-03 19:27 UTC (permalink / raw)
  To: u-boot

On Fri, 2013-12-20 at 09:24 +0530, Nikhil Badola wrote:
> From: Ramneek Mehresh <ramneek.mehresh@freescale.com>
> 
> Defines get_svr() for 83xx devices
> 
> Signed-off-by: Ramneek Mehresh <ramneek.mehresh@freescale.com>
> ---
>  arch/powerpc/cpu/mpc83xx/start.S | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/powerpc/cpu/mpc83xx/start.S b/arch/powerpc/cpu/mpc83xx/start.S
> index b4fafe6..7f74a50 100644
> --- a/arch/powerpc/cpu/mpc83xx/start.S
> +++ b/arch/powerpc/cpu/mpc83xx/start.S
> @@ -120,6 +120,11 @@ disable_addr_trans:
>  	mtspr	SRR1, r3
>  	rfi
>  
> +	.globl get_svr
> +get_svr:
> +	mfspr	r3, SVR
> +	blr
> +
>  	.globl get_pvr
>  get_pvr:
>  	mfspr	r3, PVR

Instead of this, how about turning these into straightforward
non-subarch-specific inline functions?

-Scott

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-01-03 19:27 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-20  3:54 [U-Boot] [PATCH] powerpc/83xx: fix compilation error for MPC8315ERDB Nikhil Badola
2014-01-02 21:44 ` York Sun
2014-01-03 19:27 ` Scott Wood

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox