[U-Boot] [PATCH v6 00/12] sf: Add Extended read and quad read/write commands support

[U-Boot] [PATCH v6 00/12] sf: Add Extended read and quad read/write commands support

[Jagannadha Sutradharudu Teki]

This a suffix series for
http://u-boot.10912.n7.nabble.com/PATCH-v4-00-36-sf-Add-common-probe-and-extended-quad-read-write-cmds-support-td163949.html
for adding extended read and quad read/write commands support.

Concept:
"Implementation will discover the fastest command by taking the supported
commands from flash and a controller. Controller supported commands will always been a priority."

The above concept is changed in this series as couple of reviews from earlier ones.
- Implementation concept will apply on read commands.
- As we have two write commands as of now ? so this series is not trying to
  discover the fastest write command
- The respective command modes are given to the controller driver side as a form of
  SPI RX/RX operation modes - so sf definitions will not be part of SPI driver side.

Testing branch:
$ git clone git://git.denx.de/u-boot-spi.git
$ cd u-boot-spi
$ git checkout -b master-quad origin/master-quad

REQUEST FOR ALL SPI CODE CONTRIBUTORS/USERS, PLEASE TEST THESE CHANGES
W.R.T YOUR HW IF POSSIBLE.

Please let me know for any issues/concerns/questions.

--
Thanks,
Jagan.

Changes for v6:
	- Divided flash reg ops code
	- sf_ops.c clean
Changes for v5:
        - Re-implemented write command log - not trying to discover the fastest write
        - Added SPI RX/TX operation modes
        - SPI flash parts are moved into sf_params.c file
        - Added QUAD_IO_FAST read support
        - Discovred the read dummy_cycles based on configured read cmd
        - Added set QEB support for macronix flash
        - Enabled quad read/write cmd support for macronix flash
Changes for v4:
Changes for v3:
Changes for v2:
        - none

Jagannadha Sutradharudu Teki (12):
  sf: Add extended read commands support
  sf: Add quad read/write commands support
  sf: ops: Add configuration register writing support
  sf: Set quad enable bit support
  sf: probe: Enable RD_FULL and WR_QPP
  sf: Separate the flash params table
  sf: Add QUAD_IO_FAST read support
  sf: Discover read dummy_cycles
  sf: Add macronix set QEB support
  sf: probe: Enable macronix quad read/write cmds support
  sf: Divide flash register ops from QEB code
  sf: Code cleanups

 drivers/mtd/spi/Makefile      |   4 +-
 drivers/mtd/spi/sf_internal.h |  31 +++++-
 drivers/mtd/spi/sf_ops.c      |  71 ++++++++++--
 drivers/mtd/spi/sf_params.c   | 130 ++++++++++++++++++++++
 drivers/mtd/spi/sf_probe.c    | 246 +++++++++++++++++++-----------------------
 include/spi.h                 |  17 +++
 include/spi_flash.h           |  43 ++++++++
 7 files changed, 393 insertions(+), 149 deletions(-)
 create mode 100644 drivers/mtd/spi/sf_params.c

-- 
1.8.3

[U-Boot] [PATCH v6 00/12] sf: Add Extended read and quad read/write commands support

[Sourav Poddar]

On Saturday 04 January 2014 08:34 PM, Jagannadha Sutradharudu Teki wrote:
> This a suffix series for
> http://u-boot.10912.n7.nabble.com/PATCH-v4-00-36-sf-Add-common-probe-and-extended-quad-read-write-cmds-support-td163949.html
> for adding extended read and quad read/write commands support.
>
> Concept:
> "Implementation will discover the fastest command by taking the supported
> commands from flash and a controller. Controller supported commands will always been a priority."
>
> The above concept is changed in this series as couple of reviews from earlier ones.
> - Implementation concept will apply on read commands.
> - As we have two write commands as of now ? so this series is not trying to
>    discover the fastest write command
> - The respective command modes are given to the controller driver side as a form of
>    SPI RX/RX operation modes - so sf definitions will not be part of SPI driver side.
>
> Testing branch:
> $ git clone git://git.denx.de/u-boot-spi.git
> $ cd u-boot-spi
> $ git checkout -b master-quad origin/master-quad
>
> REQUEST FOR ALL SPI CODE CONTRIBUTORS/USERS, PLEASE TEST THESE CHANGES
> W.R.T YOUR HW IF POSSIBLE.
>
> Please let me know for any issues/concerns/questions.
>
> --
> Thanks,
> Jagan.
>
> Changes for v6:
> 	- Divided flash reg ops code
> 	- sf_ops.c clean
> Changes for v5:
>          - Re-implemented write command log - not trying to discover the fastest write
>          - Added SPI RX/TX operation modes
>          - SPI flash parts are moved into sf_params.c file
>          - Added QUAD_IO_FAST read support
>          - Discovred the read dummy_cycles based on configured read cmd
>          - Added set QEB support for macronix flash
>          - Enabled quad read/write cmd support for macronix flash
> Changes for v4:
> Changes for v3:
> Changes for v2:
>          - none
>
> Jagannadha Sutradharudu Teki (12):
>    sf: Add extended read commands support
>    sf: Add quad read/write commands support
>    sf: ops: Add configuration register writing support
>    sf: Set quad enable bit support
>    sf: probe: Enable RD_FULL and WR_QPP
>    sf: Separate the flash params table
>    sf: Add QUAD_IO_FAST read support
>    sf: Discover read dummy_cycles
>    sf: Add macronix set QEB support
>    sf: probe: Enable macronix quad read/write cmds support
>    sf: Divide flash register ops from QEB code
>    sf: Code cleanups
>
>   drivers/mtd/spi/Makefile      |   4 +-
>   drivers/mtd/spi/sf_internal.h |  31 +++++-
>   drivers/mtd/spi/sf_ops.c      |  71 ++++++++++--
>   drivers/mtd/spi/sf_params.c   | 130 ++++++++++++++++++++++
>   drivers/mtd/spi/sf_probe.c    | 246 +++++++++++++++++++-----------------------
>   include/spi.h                 |  17 +++
>   include/spi_flash.h           |  43 ++++++++
>   7 files changed, 393 insertions(+), 149 deletions(-)
>   create mode 100644 drivers/mtd/spi/sf_params.c
>
Apart from the couple of comments given, this series looks good to me.