u-boot.lists.denx.de archive mirror
 help / color / mirror / Atom feed
From: Jaehoon Chung <jh80.chung@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 02/12] trats2: Code cleanup.
Date: Thu, 09 Jan 2014 21:59:23 +0900	[thread overview]
Message-ID: <52CE9D2B.3080107@samsung.com> (raw)
In-Reply-To: <1389266596-14581-3-git-send-email-p.marczak@samsung.com>

Acked-by: Jaehoon Chung <jh80.chung@samsung.com>

On 01/09/2014 08:23 PM, Przemyslaw Marczak wrote:
> Remove wrong and unused env variables
> Trats2 is not as GT-I8800.
> 
> Signed-off-by: Przemyslaw Marczak <p.marczak@samsung.com>
> Cc: Piotr Wilczek <p.wilczek@samsung.com>
> 
> ---
> Changes v2:
> - none
> 
> Changes v3:
> - none
> 
> Changes v4:
> - add "include pmic.h" to "max77686_pmic.h"
> 
>  board/samsung/trats2/trats2.c      |   19 ++-----------------
>  drivers/power/battery/bat_trats2.c |    2 +-
>  include/configs/trats2.h           |    1 -
>  include/power/max77686_pmic.h      |    2 ++
>  4 files changed, 5 insertions(+), 19 deletions(-)
> 
> diff --git a/board/samsung/trats2/trats2.c b/board/samsung/trats2/trats2.c
> index 1e96fdc..b4ccf51 100644
> --- a/board/samsung/trats2/trats2.c
> +++ b/board/samsung/trats2/trats2.c
> @@ -72,15 +72,12 @@ static void check_hw_revision(void)
>  int checkboard(void)
>  {
>  	puts("Board:\tTRATS2\n");
> +	printf("HW Revision:\t0x%04x\n", board_rev);
> +
>  	return 0;
>  }
>  #endif
>  
> -static void show_hw_revision(void)
> -{
> -	printf("HW Revision:\t0x%04x\n", board_rev);
> -}
> -
>  u32 get_board_rev(void)
>  {
>  	return board_rev;
> @@ -614,15 +611,3 @@ void init_panel_info(vidinfo_t *vid)
>  	exynos_set_dsim_platform_data(&dsim_platform_data);
>  }
>  #endif /* LCD */
> -
> -#ifdef CONFIG_MISC_INIT_R
> -int misc_init_r(void)
> -{
> -	setenv("model", "GT-I8800");
> -	setenv("board", "TRATS2");
> -
> -	show_hw_revision();
> -
> -	return 0;
> -}
> -#endif
> diff --git a/drivers/power/battery/bat_trats2.c b/drivers/power/battery/bat_trats2.c
> index f264832..94015aa 100644
> --- a/drivers/power/battery/bat_trats2.c
> +++ b/drivers/power/battery/bat_trats2.c
> @@ -8,7 +8,7 @@
>  #include <common.h>
>  #include <power/pmic.h>
>  #include <power/battery.h>
> -#include <power/max8997_pmic.h>
> +#include <power/max77693_pmic.h>
>  #include <errno.h>
>  
>  static struct battery battery_trats;
> diff --git a/include/configs/trats2.h b/include/configs/trats2.h
> index c9ce828..7dfbe98 100644
> --- a/include/configs/trats2.h
> +++ b/include/configs/trats2.h
> @@ -272,7 +272,6 @@
>  #define CONFIG_EFI_PARTITION
>  #define CONFIG_PARTITION_UUIDS
>  
> -#define CONFIG_MISC_INIT_R
>  #define CONFIG_BOARD_EARLY_INIT_F
>  
>  /* I2C */
> diff --git a/include/power/max77686_pmic.h b/include/power/max77686_pmic.h
> index 16e9016..c2a772a 100644
> --- a/include/power/max77686_pmic.h
> +++ b/include/power/max77686_pmic.h
> @@ -8,6 +8,8 @@
>  #ifndef __MAX77686_H_
>  #define __MAX77686_H_
>  
> +#include <power/pmic.h>
> +
>  enum {
>  	MAX77686_REG_PMIC_ID		= 0x0,
>  	MAX77686_REG_PMIC_INTSRC,
> 

  reply	other threads:[~2014-01-09 12:59 UTC|newest]

Thread overview: 147+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-03 18:03 [U-Boot] [PATCH 00/10] Introduce Samsung misc file and LCD menu Przemyslaw Marczak
2013-12-03 18:03 ` [U-Boot] [PATCH 01/10] s5p: gpio: change gpio coding method for s5p gpio Przemyslaw Marczak
2013-12-03 18:03 ` [U-Boot] [PATCH 02/10] trats2: Code cleanup Przemyslaw Marczak
2013-12-03 18:03 ` [U-Boot] [PATCH 03/10] samsung: common: Add misc file and common function misc_init_r() Przemyslaw Marczak
2013-12-11  8:16   ` Minkyu Kang
2013-12-11 10:00     ` Przemyslaw Marczak
2013-12-03 18:03 ` [U-Boot] [PATCH 04/10] samsung: misc: move display logo function to misc.c file Przemyslaw Marczak
2013-12-10  9:47   ` 황형원
2013-12-11  8:16   ` Minkyu Kang
2013-12-03 18:03 ` [U-Boot] [PATCH 05/10] lib: tizen: add Tizen 16bpp logo support Przemyslaw Marczak
     [not found]   ` <01a201cef56e$6f3e3ac0$4dbab040$@samsung.com>
2013-12-10  7:41     ` Przemyslaw Marczak
     [not found]   ` <20131211105613.201446ff68c75747d836fab7@samsung.com>
2013-12-11 13:48     ` Przemyslaw Marczak
2013-12-03 18:03 ` [U-Boot] [PATCH 06/10] video: exynos: fimd: always use 16bpp display mode Przemyslaw Marczak
     [not found]   ` <018001cef563$f1baed50$d530c7f0$@samsung.com>
2013-12-10  5:47     ` [U-Boot] FW: " Donghwa Lee
2013-12-10  8:15       ` Przemyslaw Marczak
2013-12-10  8:55         ` Ajay kumar
2013-12-10  9:02         ` [U-Boot] " Donghwa Lee
2013-12-03 18:03 ` [U-Boot] [PATCH 07/10] samsung: misc: Add LCD download menu Przemyslaw Marczak
2013-12-11  8:15   ` Minkyu Kang
2013-12-11 12:38     ` Przemyslaw Marczak
2013-12-03 18:03 ` [U-Boot] [PATCH 08/10] Trats: add LCD download menu support Przemyslaw Marczak
2013-12-04  6:08   ` Lukasz Majewski
2013-12-11  8:15   ` Minkyu Kang
2013-12-11 13:32     ` Przemyslaw Marczak
2013-12-03 18:03 ` [U-Boot] [PATCH 09/10] trats2: " Przemyslaw Marczak
2013-12-03 18:03 ` [U-Boot] [PATCH 10/10] universal: " Przemyslaw Marczak
2013-12-04  1:29 ` [U-Boot] [PATCH 00/10] Introduce Samsung misc file and LCD menu TigerLiu at viatech.com.cn
2013-12-04 12:11   ` Przemyslaw Marczak
2013-12-18 18:31 ` [U-Boot] [PATCH v2 00/13] " Przemyslaw Marczak
2013-12-18 18:31   ` [U-Boot] [PATCH v2 01/13] s5p: gpio: change gpio coding method for s5p gpio Przemyslaw Marczak
2014-01-02  6:35     ` Minkyu Kang
2014-01-02  7:55       ` Przemyslaw Marczak
2013-12-18 18:31   ` [U-Boot] [PATCH v2 02/13] trats: add optional cflags to board object file Przemyslaw Marczak
2014-01-02  6:35     ` Minkyu Kang
2014-01-02  8:03       ` Przemyslaw Marczak
2013-12-18 18:31   ` [U-Boot] [PATCH v2 03/13] trats2: Code cleanup Przemyslaw Marczak
2013-12-18 18:31   ` [U-Boot] [PATCH v2 04/13] samsung: common: Add misc file and common function misc_init_r() Przemyslaw Marczak
2014-01-02  6:37     ` Minkyu Kang
2014-01-02  8:09       ` Przemyslaw Marczak
2013-12-18 18:31   ` [U-Boot] [PATCH v2 05/13] samsung: misc: move display logo function to misc.c file Przemyslaw Marczak
2013-12-18 18:31   ` [U-Boot] [PATCH v2 06/13] common: makefile: Add optional cflags to object: common/lcd.o Przemyslaw Marczak
2013-12-19  5:44     ` Inha Song
2014-01-02  6:35     ` Minkyu Kang
2013-12-18 18:31   ` [U-Boot] [PATCH v2 07/13] lib: tizen: change Tizen logo with the new one Przemyslaw Marczak
2013-12-19  5:40     ` 황형원
2013-12-19 10:40       ` Przemyslaw Marczak
2013-12-20  5:07         ` Hyungwon Hwang
2013-12-20 11:50           ` Przemyslaw Marczak
2013-12-25 23:39             ` Hyungwon Hwang
2013-12-30 15:46               ` Przemyslaw Marczak
2013-12-18 18:31   ` [U-Boot] [PATCH v2 08/13] video: exynos: fimd: add support for various display color modes Przemyslaw Marczak
2013-12-19  5:08     ` Donghwa Lee
2013-12-18 18:31   ` [U-Boot] [PATCH v2 09/13] samsung: boards: update display configs with 16bpp mode Przemyslaw Marczak
2013-12-18 18:31   ` [U-Boot] [PATCH v2 10/13] samsung: misc: Add LCD download menu Przemyslaw Marczak
2013-12-18 18:31   ` [U-Boot] [PATCH v2 11/13] Trats: add LCD download menu support Przemyslaw Marczak
2013-12-18 18:31   ` [U-Boot] [PATCH v2 12/13] trats2: " Przemyslaw Marczak
2014-01-02  6:34     ` Minkyu Kang
2013-12-18 18:31   ` [U-Boot] [PATCH v2 13/13] universal: " Przemyslaw Marczak
2014-01-03 16:43 ` [U-Boot] [PATCH v3 01/12] s5p: gpio: change gpio coding method for s5p gpio Przemyslaw Marczak
2014-01-03 16:43   ` [U-Boot] [PATCH v3 02/12] trats2: Code cleanup Przemyslaw Marczak
2014-01-03 16:43   ` [U-Boot] [PATCH v3 03/12] samsung: common: Add misc file and common function misc_init_r() Przemyslaw Marczak
2014-01-03 16:43   ` [U-Boot] [PATCH v3 04/12] samsung: misc: move display logo function to misc.c file Przemyslaw Marczak
2014-01-03 16:43   ` [U-Boot] [PATCH v3 05/12] common: lcd.c: fix data abort exception when try to access bmp header Przemyslaw Marczak
2014-01-06  5:05     ` Minkyu Kang
2014-01-06  8:54     ` Anatolij Gustschin
2014-01-03 16:43   ` [U-Boot] [PATCH v3 06/12] lib: tizen: change Tizen logo with the new one Przemyslaw Marczak
2014-01-03 16:43   ` [U-Boot] [PATCH v3 07/12] video: exynos: fimd: add support for various display color modes Przemyslaw Marczak
2014-01-03 16:43   ` [U-Boot] [PATCH v3 08/12] samsung: boards: update display configs with 16bpp mode Przemyslaw Marczak
2014-01-03 16:43   ` [U-Boot] [PATCH v3 09/12] samsung: misc: Add LCD download menu Przemyslaw Marczak
2014-01-06 11:38     ` Minkyu Kang
2014-01-07 12:46       ` Przemyslaw Marczak
2014-01-03 16:43   ` [U-Boot] [PATCH v3 10/12] Trats: add LCD download menu support Przemyslaw Marczak
2014-01-03 17:20     ` Przemyslaw Marczak
2014-01-03 16:43   ` [U-Boot] [PATCH v3 11/12] trats2: " Przemyslaw Marczak
2014-01-03 17:21     ` Przemyslaw Marczak
2014-01-06 11:37       ` Minkyu Kang
2014-01-07 12:54         ` Przemyslaw Marczak
2014-01-08  1:56           ` Minkyu Kang
2014-01-08 13:47             ` Przemyslaw Marczak
2014-01-03 16:43   ` [U-Boot] [PATCH v3 12/12] universal: " Przemyslaw Marczak
2014-01-03 17:23     ` Przemyslaw Marczak
2014-01-03 17:31       ` Przemyslaw Marczak
2014-01-06 11:37   ` [U-Boot] [PATCH v3 01/12] s5p: gpio: change gpio coding method for s5p gpio Minkyu Kang
2014-01-07 12:56     ` Przemyslaw Marczak
2014-01-09 11:23 ` [U-Boot] [PATCH v4 00/12] Introduce Samsung misc file and LCD menu Przemyslaw Marczak
2014-01-09 11:23   ` [U-Boot] [PATCH v4 01/12] s5p: gpio: change gpio coding method for s5p gpio Przemyslaw Marczak
2014-01-09 11:23   ` [U-Boot] [PATCH v4 02/12] trats2: Code cleanup Przemyslaw Marczak
2014-01-09 12:59     ` Jaehoon Chung [this message]
2014-01-09 11:23   ` [U-Boot] [PATCH v4 03/12] samsung: common: Add misc file and common function misc_init_r() Przemyslaw Marczak
2014-01-09 13:00     ` Jaehoon Chung
2014-01-09 11:23   ` [U-Boot] [PATCH v4 04/12] samsung: misc: move display logo function to misc.c file Przemyslaw Marczak
2014-01-09 11:23   ` [U-Boot] [PATCH v4 05/12] common: lcd.c: fix data abort exception when try to access bmp header Przemyslaw Marczak
2014-01-09 11:23   ` [U-Boot] [PATCH v4 06/12] lib: tizen: change Tizen logo with the new one Przemyslaw Marczak
2014-01-10  7:09     ` Hyungwon Hwang
2014-01-10  9:26     ` Hyungwon Hwang
2014-01-10  9:35       ` Przemyslaw Marczak
2014-01-09 11:23   ` [U-Boot] [PATCH v4 07/12] video: exynos: fimd: add support for various display color modes Przemyslaw Marczak
2014-01-09 11:23   ` [U-Boot] [PATCH v4 08/12] samsung: boards: update display configs with 16bpp mode Przemyslaw Marczak
2014-01-09 11:23   ` [U-Boot] [PATCH v4 09/12] samsung: misc: Add LCD download menu Przemyslaw Marczak
2014-01-10  1:37     ` Minkyu Kang
2014-01-10  9:37       ` Przemyslaw Marczak
2014-01-10  9:43         ` Minkyu Kang
2014-01-10  9:48           ` Przemyslaw Marczak
2014-01-09 11:23   ` [U-Boot] [PATCH v4 10/12] Trats: add LCD download menu support Przemyslaw Marczak
2014-01-09 11:23   ` [U-Boot] [PATCH v4 11/12] trats2: " Przemyslaw Marczak
2014-01-09 11:23   ` [U-Boot] [PATCH v4 12/12] universal: " Przemyslaw Marczak
2014-01-10  6:45   ` [U-Boot] [PATCH v4 00/12] Introduce Samsung misc file and LCD menu Hyungwon Hwang
2014-01-10  7:06     ` Hyungwon Hwang
2014-01-10  9:31     ` Przemyslaw Marczak
2014-01-10 14:31 ` [U-Boot] [PATCH v5 " Przemyslaw Marczak
2014-01-10 14:31   ` [U-Boot] [PATCH v5 01/12] s5p: gpio: change gpio coding method for s5p gpio Przemyslaw Marczak
2014-01-10 14:31   ` [U-Boot] [PATCH v5 02/12] trats2: Code cleanup Przemyslaw Marczak
2014-01-10 14:31   ` [U-Boot] [PATCH v5 03/12] samsung: common: Add misc file and common function misc_init_r() Przemyslaw Marczak
2014-01-14 13:55     ` Przemyslaw Marczak
2014-01-15  7:35       ` Minkyu Kang
2014-01-15  7:51         ` Przemyslaw Marczak
2014-01-15  8:08           ` Piotr Wilczek
2014-01-15  8:18             ` Przemyslaw Marczak
2014-01-17  6:26               ` Minkyu Kang
2014-01-17  8:36                 ` Przemyslaw Marczak
2014-01-20  7:06                   ` Minkyu Kang
2014-01-10 14:31   ` [U-Boot] [PATCH v5 04/12] samsung: misc: move display logo function to misc.c file Przemyslaw Marczak
2014-01-14  3:41     ` Jaehoon Chung
2014-01-14  8:02       ` Przemyslaw Marczak
2014-01-14  8:55         ` Minkyu Kang
2014-01-15 10:20           ` Przemyslaw Marczak
2014-01-10 14:31   ` [U-Boot] [PATCH v5 05/12] common: lcd.c: fix data abort exception when try to access bmp header Przemyslaw Marczak
2014-01-10 14:32   ` [U-Boot] [PATCH v5 06/12] lib: tizen: change Tizen logo with the new one Przemyslaw Marczak
2014-01-10 14:32   ` [U-Boot] [PATCH v5 07/12] video: exynos: fimd: add support for various display color modes Przemyslaw Marczak
2014-01-10 14:32   ` [U-Boot] [PATCH v5 08/12] samsung: boards: update display configs with 16bpp mode Przemyslaw Marczak
2014-01-10 14:32   ` [U-Boot] [PATCH v5 09/12] samsung: misc: Add LCD download menu Przemyslaw Marczak
2014-01-10 14:32   ` [U-Boot] [PATCH v5 10/12] Trats: add LCD download menu support Przemyslaw Marczak
2014-01-10 14:32   ` [U-Boot] [PATCH v5 11/12] trats2: " Przemyslaw Marczak
2014-01-10 14:32   ` [U-Boot] [PATCH v5 12/12] universal: " Przemyslaw Marczak
2014-01-22 10:24 ` [U-Boot] [PATCH v6 00/11] Introduce Samsung misc file and LCD menu Przemyslaw Marczak
2014-01-22 10:24   ` [U-Boot] [PATCH v6 01/11] s5p: gpio: change gpio coding method for s5p gpio Przemyslaw Marczak
2014-01-22 10:24   ` [U-Boot] [PATCH v6 02/11] trats2: Code cleanup Przemyslaw Marczak
2014-01-22 10:24   ` [U-Boot] [PATCH v6 03/11] samsung: common: Add file for common functions, draw_logo() cleanup Przemyslaw Marczak
2014-01-22 10:24   ` [U-Boot] [PATCH v6 04/11] common: lcd.c: fix data abort exception when try to access bmp header Przemyslaw Marczak
2014-01-22 10:24   ` [U-Boot] [PATCH v6 05/11] lib: tizen: change Tizen logo with the new one Przemyslaw Marczak
2014-01-22 10:24   ` [U-Boot] [PATCH v6 06/11] video: exynos: fimd: add support for various display color modes Przemyslaw Marczak
2014-01-22 10:24   ` [U-Boot] [PATCH v6 07/11] samsung: boards: update display configs with 16bpp mode Przemyslaw Marczak
2014-01-22 10:24   ` [U-Boot] [PATCH v6 08/11] samsung: misc: Add LCD download menu Przemyslaw Marczak
2014-01-22 10:24   ` [U-Boot] [PATCH v6 09/11] trats: add LCD download menu support Przemyslaw Marczak
2014-01-22 10:24   ` [U-Boot] [PATCH v6 10/11] trats2: " Przemyslaw Marczak
2014-01-22 10:24   ` [U-Boot] [PATCH v6 11/11] universal: " Przemyslaw Marczak
2014-02-03  7:06   ` [U-Boot] [PATCH v6 00/11] Introduce Samsung misc file and LCD menu Minkyu Kang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52CE9D2B.3080107@samsung.com \
    --to=jh80.chung@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).