From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jaehoon Chung Date: Fri, 10 Jan 2014 14:08:59 +0900 Subject: [U-Boot] [PATCH 8/9] ums: always initialize mmc before ums_disk_init() In-Reply-To: <1389277919-15279-8-git-send-email-m.zalega@samsung.com> References: <1389277919-15279-1-git-send-email-m.zalega@samsung.com> <1389277919-15279-8-git-send-email-m.zalega@samsung.com> Message-ID: <52CF806B.1020406@samsung.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Mateusz, On 01/09/2014 11:31 PM, Mateusz Zalega wrote: > In some cases MMC was still uninitialized while media capacity check, > leading to broken ums command. > > Change-Id: I4b86c2c59e430fb8b55272ea14f00316d8cb3dca > Signed-off-by: Mateusz Zalega > Cc: Lukasz Majewski > Cc: Minkyu Kang > Cc: Kyungmin Park > --- > board/samsung/common/ums.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/board/samsung/common/ums.c b/board/samsung/common/ums.c > index dc155ad..0d8f30d 100644 > --- a/board/samsung/common/ums.c > +++ b/board/samsung/common/ums.c > @@ -37,6 +37,9 @@ static struct ums ums_dev = { > > static struct ums *ums_disk_init(struct mmc *mmc) > { > + if (mmc_init(mmc)) > + return NULL; > + > uint64_t mmc_end_sector = mmc->capacity / SECTOR_SIZE; > uint64_t ums_end_sector = UMS_NUM_SECTORS + UMS_START_SECTOR; --> if (mmc_init(mmc)) return NULL; Locate this point. Best Regards, Jaehoon Chung > >