From: Minkyu Kang <mk7.kang@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] fuelgauge: max17042: fix i2c read issue which causes infinity loop.
Date: Tue, 14 Jan 2014 09:24:32 +0900 [thread overview]
Message-ID: <52D483C0.2020708@samsung.com> (raw)
In-Reply-To: <52D3B195.7000504@samsung.com>
On 13/01/14 18:27, Przemyslaw Marczak wrote:
> Hello Minkyu,
>
> On 12/30/2013 11:31 AM, Przemyslaw Marczak wrote:
>> Hello,
>>
>> On 12/30/2013 11:24 AM, Przemyslaw Marczak wrote:
>>> Issues:
>>> - reading i2c data by passing u16 pointer causes errors in read data.
>>> - max17042 status register fields have not only Power On Reset meaning
>>> so using proper mask is required.
>>>
>>> Changes:
>>> - read i2c data to type u32 instead of u16 - avoids buffer overflow
>>> - compare FG status register using mask not just one bit value
>>> - add checking return value to functions fg read/write
>>> - add model lock and model check count
>>> - add debug msg
>>>
>>> Signed-off-by: Przemyslaw Marczak <p.marczak@samsung.com>
>>> Cc: Lukasz Majewski <l.majewski@samsung.com>
>>> Cc: Minkyu Kang <mk7.kang@samsung.com>
>>>
>>> ---
>>> Changes v2:
>>> - add checking return value to functions fg read/write
>>> - add model lock and model check count
>>> - add status msg
>>> - change logical AND to bitwise AND when checking status register
>>>
>>
>> To test this patch, it is required to apply trats i2c fix by Piotr Wilczek:
>> "[PATCH] board:trats1:trats2: fix adapter number"
>> which can be found at u-boot list.
>> In other way FG will be not initialized.
>>
>> Regards,
>
> Could you review this patch, please?
> Is it possible to apply this before the release?
> It is useful fix.
>
> Thank you,
This patch was delegated to Tom.
Thanks,
Minkyu Kang.
next prev parent reply other threads:[~2014-01-14 0:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-10 15:19 [U-Boot] [PATCH] fuelgauge: max17042: fix i2c read issue which causes infinity loop Przemyslaw Marczak
2013-12-11 2:27 ` Minkyu Kang
2013-12-30 10:24 ` [U-Boot] [PATCH v2] " Przemyslaw Marczak
2013-12-30 10:31 ` Przemyslaw Marczak
2014-01-13 9:27 ` Przemyslaw Marczak
2014-01-14 0:24 ` Minkyu Kang [this message]
2014-01-14 7:48 ` Przemyslaw Marczak
2014-01-14 21:02 ` [U-Boot] [U-Boot, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D483C0.2020708@samsung.com \
--to=mk7.kang@samsung.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).