From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mateusz Zalega <m.zalega@samsung.com>
Date: Tue, 14 Jan 2014 11:55:16 +0100
Subject: [U-Boot] [PATCH 8/9] ums: always initialize mmc before
	ums_disk_init()
In-Reply-To: <52D48987.4040306@samsung.com>
References: <1389277919-15279-1-git-send-email-m.zalega@samsung.com>
	<1389277919-15279-8-git-send-email-m.zalega@samsung.com>
	<52D48987.4040306@samsung.com>
Message-ID: <52D51794.9040001@samsung.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 01/14/14 01:49, Minkyu Kang wrote:
> On 09/01/14 23:31, Mateusz Zalega wrote:
>> In some cases MMC was still uninitialized while media capacity check,
>> leading to broken ums command.
>>
>> Change-Id: I4b86c2c59e430fb8b55272ea14f00316d8cb3dca
>> Signed-off-by: Mateusz Zalega <m.zalega@samsung.com>
>> Cc: Lukasz Majewski <l.majewski@samsung.com>
>> Cc: Minkyu Kang <mk7.kang@samsung.com>
>> Cc: Kyungmin Park <kyungmin.park@samsung.com>
>> ---
>>  board/samsung/common/ums.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/board/samsung/common/ums.c b/board/samsung/common/ums.c
>> index dc155ad..0d8f30d 100644
>> --- a/board/samsung/common/ums.c
>> +++ b/board/samsung/common/ums.c
>> @@ -37,6 +37,9 @@ static struct ums ums_dev = {
>>  
>>  static struct ums *ums_disk_init(struct mmc *mmc)
>>  {
>> +	if (mmc_init(mmc))
>> +		return NULL;
>> +
>>  	uint64_t mmc_end_sector = mmc->capacity / SECTOR_SIZE;
>>  	uint64_t ums_end_sector = UMS_NUM_SECTORS + UMS_START_SECTOR;
>>  
>>
> 
> Why don't you init the mmc before call this function?
> 
> diff --git a/board/samsung/common/ums.c b/board/samsung/common/ums.c
> index dc155ad..7017c2a 100644
> --- a/board/samsung/common/ums.c
> +++ b/board/samsung/common/ums.c
> @@ -72,5 +72,8 @@ struct ums *ums_init(unsigned int dev_num)
>         if (!mmc)
>                 return NULL;
>  
> +       if (mmc_init(mmc))
> +               return NULL;
> +
>         return ums_disk_init(mmc);
>  }

I agree, ACK.

-- 
Mateusz Zalega
Samsung R&D Institute Poland