From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ARM: tegra20: Add a missing entry in the pullid enum
Date: Wed, 15 Jan 2014 11:36:03 -0700 [thread overview]
Message-ID: <52D6D513.7030506@wwwdotorg.org> (raw)
In-Reply-To: <1389797710-14396-1-git-send-email-alban.bedel@avionic-design.de>
On 01/15/2014 07:55 AM, Alban Bedel wrote:
> It seems two entries were merged in one when this file has been
> created. The GPSLXAU entries is obviously a mix of GPU and SLXA which
> are next to each other according to the datasheet. Moreover it can be
> noticed because the APB_MISC_PP_PULLUPDOWN_REG_B_0 register only have
> 15 entries instead of 16.
>
> Also fix the pin group descriptions that were using these buggy
> entries. In particular SLXA that needed to used CRTP to actually
> write the SLXA register.
This does appear to match the kernel's pinctrl driver, so,
Acked-by: Stephen Warren <swarren@nvidia.com>
I wonder how many more similar issues there are. Did you check the whole
file for this kind of issue, or just debug a problem with one particular
pin/group?
next prev parent reply other threads:[~2014-01-15 18:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-15 14:55 [U-Boot] [PATCH] ARM: tegra20: Add a missing entry in the pullid enum Alban Bedel
2014-01-15 18:36 ` Stephen Warren [this message]
2014-01-20 10:24 ` Alban Bedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D6D513.7030506@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).