From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Warren <swarren@wwwdotorg.org>
Date: Thu, 16 Jan 2014 13:03:03 -0700
Subject: [U-Boot] [PATCH 1/6] cmd_pxe.c add any option for filesystem
 with sysboot uses generic load
In-Reply-To: <1387264612-17834-2-git-send-email-dennis@ausil.us>
References: <1387264612-17834-1-git-send-email-dennis@ausil.us>
	<1387264612-17834-2-git-send-email-dennis@ausil.us>
Message-ID: <52D83AF7.3010405@wwwdotorg.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 12/17/2013 12:16 AM, Dennis Gilmore wrote:
> Signed-off-by: Dennis Gilmore <dennis@ausil.us>

Nit pick: A patch description might be useful.

> @@ -1539,6 +1553,8 @@ int do_sysboot(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
>  		do_getfile = do_get_ext2;
>  	else if (strstr(argv[3], "fat"))
>  		do_getfile = do_get_fat;
> +	else if (strstr(argv[3], "any"))
> +		do_getfile = do_get_any;

This is a total bikeshed, so feel free to ignore it cmopletely:

Is "any" the best choice here? In other U-Boot commands, "-" is used to
mean something similar, so perhaps "-" would work better here? Still, I
guess "-" usually means "none" or "missing" more than "any", so perhaps
"any" is better after all. Anyway, just a point for thought; I'm fine
either way.