From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 2/2] env_mmc: default to 0 if CONFIG_SYS_MMC_ENV_DEV not defined
Date: Fri, 17 Jan 2014 12:35:54 -0700 [thread overview]
Message-ID: <52D9861A.8080607@wwwdotorg.org> (raw)
In-Reply-To: <1389950098-18122-2-git-send-email-hector.palacios@digi.com>
On 01/17/2014 02:14 AM, Hector Palacios wrote:
> Since function mmc_get_env_devno is __weak and can be overridden by
> board code, boards do not need to mandatory define
> CONFIG_SYS_MMC_ENV_DEV.
> If the constant is not defined, define it to 0 by default.
> diff --git a/common/env_mmc.c b/common/env_mmc.c
> +#if !defined(CONFIG_SYS_MMC_ENV_DEV)
> +#define CONFIG_SYS_MMC_ENV_DEV 0
> +#endif
> +
> __weak int mmc_get_env_devno(void)
> {
> return CONFIG_SYS_MMC_ENV_DEV;
> +}
Oh, I guess your fixup got squashed into the wrong patch?
Aside from that issue, and those Otavio raised, the series,
Reviewed-by: Stephen Warren <swarren@nvidia.com>
next prev parent reply other threads:[~2014-01-17 19:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-17 9:14 [U-Boot] [PATCH v2 1/2] env_mmc: make board configurable the partition for the environment Hector Palacios
2014-01-17 9:14 ` [U-Boot] [PATCH v2 2/2] env_mmc: default to 0 if CONFIG_SYS_MMC_ENV_DEV not defined Hector Palacios
2014-01-17 10:51 ` Otavio Salvador
2014-01-17 19:35 ` Stephen Warren [this message]
2014-01-17 10:50 ` [U-Boot] [PATCH v2 1/2] env_mmc: make board configurable the partition for the environment Otavio Salvador
2014-01-17 19:34 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52D9861A.8080607@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).