From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Warren <swarren@wwwdotorg.org>
Date: Fri, 17 Jan 2014 12:35:54 -0700
Subject: [U-Boot] [PATCH v2 2/2] env_mmc: default to 0 if
 CONFIG_SYS_MMC_ENV_DEV not defined
In-Reply-To: <1389950098-18122-2-git-send-email-hector.palacios@digi.com>
References: <1389950098-18122-1-git-send-email-hector.palacios@digi.com>
	<1389950098-18122-2-git-send-email-hector.palacios@digi.com>
Message-ID: <52D9861A.8080607@wwwdotorg.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 01/17/2014 02:14 AM, Hector Palacios wrote:
> Since function mmc_get_env_devno is __weak and can be overridden by
> board code, boards do not need to mandatory define
> CONFIG_SYS_MMC_ENV_DEV.
> If the constant is not defined, define it to 0 by default.

> diff --git a/common/env_mmc.c b/common/env_mmc.c

> +#if !defined(CONFIG_SYS_MMC_ENV_DEV)
> +#define CONFIG_SYS_MMC_ENV_DEV 0
> +#endif
> +
>  __weak int mmc_get_env_devno(void)
>  {
>  	return CONFIG_SYS_MMC_ENV_DEV;
> +}

Oh, I guess your fixup got squashed into the wrong patch?

Aside from that issue, and those Otavio raised, the series,
Reviewed-by: Stephen Warren <swarren@nvidia.com>